[GitHub] [spark] wangyum commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config

2019-09-02 Thread GitBox
wangyum commented on issue #22570: [SPARK-25553][BUILD] Add 
EmptyInterpolatedStringChecker to scalastyle config
URL: https://github.com/apache/spark/pull/22570#issuecomment-527153587
 
 
   All tests passed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] wangyum commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config

2019-08-18 Thread GitBox
wangyum commented on issue #22570: [SPARK-25553][BUILD] Add 
EmptyInterpolatedStringChecker to scalastyle config
URL: https://github.com/apache/spark/pull/22570#issuecomment-522310023
 
 
   How about set `level="warn"`:
   ```xml
   
   ```
   The scalastyle check can pass and we can see the warning in IDEA:
   
![image](https://user-images.githubusercontent.com/5399861/63223364-ce57a500-c1e6-11e9-8ffa-cee0bc007dac.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] wangyum commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config

2019-08-17 Thread GitBox
wangyum commented on issue #22570: [SPARK-25553][BUILD] Add 
EmptyInterpolatedStringChecker to scalastyle config
URL: https://github.com/apache/spark/pull/22570#issuecomment-51893
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] wangyum commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config

2019-08-17 Thread GitBox
wangyum commented on issue #22570: [SPARK-25553][BUILD] Add 
EmptyInterpolatedStringChecker to scalastyle config
URL: https://github.com/apache/spark/pull/22570#issuecomment-522211998
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] wangyum commented on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config

2019-08-15 Thread GitBox
wangyum commented on issue #22570: [SPARK-25553][BUILD] Add 
EmptyInterpolatedStringChecker to scalastyle config
URL: https://github.com/apache/spark/pull/22570#issuecomment-521890373
 
 
   @srowen @maropu Do you think we can add it for Spark 3.0?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org