[GitHub] spark issue #14265: [PySpark] add picklable SparseMatrix in pyspark.ml.commo...
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/14265 @srowen We can check python/ml/tests.py, `VectorTests.test_serialize` function, it contains a test for `SparseMatrix` serializing/unserializing, so that we can confirm that this works. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14265: [PySpark] add picklable SparseMatrix in pyspark.ml.commo...
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/14265 LGTM, merged into master. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14265: [PySpark] add picklable SparseMatrix in pyspark.ml.commo...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14265 @holdenk or @MLnick do you happen to know if this sounds right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14265: [PySpark] add picklable SparseMatrix in pyspark.ml.commo...
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/14265 cc @jkbradley Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14265: [PySpark] add picklable SparseMatrix in pyspark.ml.commo...
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/14265 cc @rxin Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14265: [PySpark] add picklable SparseMatrix in pyspark.ml.commo...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14265 This isn't really my area, but I that sounds plausible --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14265: [PySpark] add picklable SparseMatrix in pyspark.ml.commo...
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/14265 @srowen I guess the `_picklable_classes` list in `ml.linalg.common` is copied from `mllib.linalg.common` so it forgot to add the `SparseMatrix` which is added later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14265: [PySpark] add picklable SparseMatrix in pyspark.ml.commo...
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/14265 @srowen I check the ml.python.MLSerde and it support SparseMatrix pickler and at python side the SparseMatrix constructor also match the pickler. So I think the `_picklable_classes` forgot to add `SparkMatrix`, or there is some other reason not to add SparseMatrix to the class list ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14265: [PySpark] add picklable SparseMatrix in pyspark.ml.commo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14265 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14265: [PySpark] add picklable SparseMatrix in pyspark.ml.commo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14265 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62536/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14265: [PySpark] add picklable SparseMatrix in pyspark.ml.commo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14265 **[Test build #62536 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62536/consoleFull)** for PR 14265 at commit [`482d7ff`](https://github.com/apache/spark/commit/482d7ff2d5518ccf63f8dc7f22a3b5ad14f63848). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14265: [PySpark] add picklable SparseMatrix in pyspark.ml.commo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14265 **[Test build #62536 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62536/consoleFull)** for PR 14265 at commit [`482d7ff`](https://github.com/apache/spark/commit/482d7ff2d5518ccf63f8dc7f22a3b5ad14f63848). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
