[GitHub] spark issue #15143: [SPARK-17584][Test] - Add unit test coverage for TaskSta...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15143 OK, can you modify the title? it becomes the commit message. "Minor code change to TaskState and Task" or something. Normally I'd say this is too trivial to commit by itself but I know it didn't start that way, and because it's a first commit I'm more inclined to merge even a little part of it to get you through the process once. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15143: [SPARK-17584][Test] - Add unit test coverage for TaskSta...
Github user erenavsarogullari commented on the issue: https://github.com/apache/spark/pull/15143 Thanks @srowen for the comment. The change-set looks ready. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15143: [SPARK-17584][Test] - Add unit test coverage for TaskSta...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15143 This is to some degree covered by other tests, yes. It's probably just not worth 100 lines of test code to test the contents of a Set from all angles. I think the other two non-test changes are trivial but I'd be willing to commit them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15143: [SPARK-17584][Test] - Add unit test coverage for TaskSta...
Github user erenavsarogullari commented on the issue: https://github.com/apache/spark/pull/15143 Hi @rxin, Firstly, thanks for quick reply. I was thinking for unit-test coverage perspective and a starter point to contribute project but it is ok for me if PR is closed as well ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15143: [SPARK-17584][Test] - Add unit test coverage for TaskSta...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15143 hm I agree having good unit test coverage is important -- this seems too trivial to test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15143: [SPARK-17584][Test] - Add unit test coverage for TaskSta...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15143 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
