Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20997
That being the case, merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20997
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20997
**[Test build #90989 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90989/testReport)**
for PR 20997 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20997
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90989/
Test PASSed.
---
Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/20997
I'm fine as well.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20997
**[Test build #90989 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90989/testReport)**
for PR 20997 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20997
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20997
I'm fine with it. Unless Cody beats me to it or has more comments, I'll
push this after the long weekend.
---
-
To unsubscribe,
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20997
Do I need to do any further changes?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20997
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20997
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90044/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20997
**[Test build #90044 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90044/testReport)**
for PR 20997 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20997
**[Test build #90044 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90044/testReport)**
for PR 20997 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20997
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20997
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89676/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20997
**[Test build #89676 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89676/testReport)**
for PR 20997 at commit
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20997
In the meantime found a small glitch in the SQL part. Namely if reattempt
happens this line
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20997
**[Test build #89676 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89676/testReport)**
for PR 20997 at commit
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20997
Taken a look at the pool options I have the feeling it requires more time
to come up with a proper solution. Switching back to the SQL code provided one
cached consumer approach...
---
Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/20997
I think if we can't come up with a pool design now that solves most of the
issues, we should switch back to the one cached consumer approach that the
SQL code is using.
On Mon, Apr
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20997
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20997
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89359/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20997
**[Test build #89359 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89359/testReport)**
for PR 20997 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20997
**[Test build #89359 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89359/testReport)**
for PR 20997 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20997
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89344/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20997
**[Test build #89344 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89344/testReport)**
for PR 20997 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20997
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20997
**[Test build #89344 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89344/testReport)**
for PR 20997 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20997
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20997
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89275/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20997
**[Test build #89275 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89275/testReport)**
for PR 20997 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20997
**[Test build #89275 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89275/testReport)**
for PR 20997 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20997
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20997
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89274/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20997
**[Test build #89274 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89274/testReport)**
for PR 20997 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20997
**[Test build #89274 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89274/testReport)**
for PR 20997 at commit
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20997
@koeninger
> I don't see an upper bound on the number of consumers per key, nor a way
of reaping idle consumers. If the SQL equivalent code is likely to be modified
to use pooling
Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/20997
In general, 2 things about this make me uncomfortable:
- It's basically a cut-and-paste of the SQL equivalent PR,
https://github.com/apache/spark/pull/20767, but it is different from both
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20997
cc @tdas @zsxwing @koeninger
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20997
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88990/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20997
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20997
**[Test build #88990 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88990/testReport)**
for PR 20997 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20997
**[Test build #88990 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88990/testReport)**
for PR 20997 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20997
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
44 matches
Mail list logo
