[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-166436451 Merging into master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4674 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-165870984 @andrewor14 Yes, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-165923851 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-165937113 **[Test build #2236 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2236/consoleFull)** for PR 4674 at commit [`c1e2303`](https://github.com/apache/spark/commit/c1e230380f8b88ebe7188f5a18d77a8b7fad9297). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_:\n * `class GraphLoaderSuite extends SparkFunSuite with LocalSparkContext `\n --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-165936016 **[Test build #2236 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2236/consoleFull)** for PR 4674 at commit [`c1e2303`](https://github.com/apache/spark/commit/c1e230380f8b88ebe7188f5a18d77a8b7fad9297). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-165547154 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-165358131 @andrewor14 @ankurdave Fixed. Also, could you merge #4399? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-165354761 @andrewor14 okay --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4674#discussion_r47691009
--- Diff:
graphx/src/test/scala/org/apache/spark/graphx/GraphLoaderSuite.scala ---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.graphx
+
+import java.io.{File, OutputStreamWriter, FileOutputStream}
+
+import org.apache.spark.util.Utils
+import org.scalatest.FunSuite
+
+class GraphLoaderSuite extends FunSuite with LocalSparkContext {
--- End diff --
this is outdated. You now need to extend `org.apache.spark.SparkFunSuite`
instead of `FunSuite` directly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-164881132 retest this please (this should fail scala style tests because of the issue I brought up) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-164881339 @maropu would you mind bringing this up to date in master? @ankurdave this looks like an OK change. Is it good to merge once it's rebased? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-133543920 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-133544483 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41382/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-133544479 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-133544285 [Test build #41382 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41382/consoleFull) for PR 4674 at commit [`cc5ac0b`](https://github.com/apache/spark/commit/cc5ac0b08ca39c3c339fdca905779bb3b037f8fa). * This patch **does not merge cleanly**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-133543992 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-133544466 [Test build #41382 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41382/consoleFull) for PR 4674 at commit [`cc5ac0b`](https://github.com/apache/spark/commit/cc5ac0b08ca39c3c339fdca905779bb3b037f8fa). * This patch **fails to build**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-122296632 @ankurdave are you progressing with this PR or should we close it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-96769601 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-75034020 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27719/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-75034010 [Test build #27719 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27719/consoleFull) for PR 4674 at commit [`cc5ac0b`](https://github.com/apache/spark/commit/cc5ac0b08ca39c3c339fdca905779bb3b037f8fa). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class GraphLoaderSuite extends FunSuite with LocalSparkContext ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-75022368 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-75022575 [Test build #27719 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27719/consoleFull) for PR 4674 at commit [`cc5ac0b`](https://github.com/apache/spark/commit/cc5ac0b08ca39c3c339fdca905779bb3b037f8fa). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5882][GraphX] Add a test for GraphLoade...
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/4674#issuecomment-74880353 Fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
