[GitHub] spark pull request: SPARK-1972: Added support for tracking custom ...
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/918#issuecomment-62331367 I'd like to close this issue for now and keep the JIRA around. This is a completely reasonable way to accomplish adding custom metrics, but this overlaps a good amount with Accumulators and their display in the UI - which I think is our longer term API for doing things like this. Anyways let's keep this patch and the JIRA around and we can consider it in the future. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-1972: Added support for tracking custom ...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/918 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-1972: Added support for tracking custom ...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/918#issuecomment-55335538 Interesting idea. @kalpit have you looked into using accumulators for custom metrics instead? See #1309. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-1972: Added support for tracking custom ...
Github user otisg commented on the pull request: https://github.com/apache/spark/pull/918#issuecomment-55212495 Can custom metrics be sent anywhere else other than having them in the UI? I'd like to send them to SPM as Custom Metrics (https://sematext.atlassian.net/wiki/display/PUBSPM/Custom+Metrics). Any suggestions @kalpit ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-1972: Added support for tracking custom ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/918#issuecomment-54694686 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-1972: Added support for tracking custom ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/918#issuecomment-53199274 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-1972: Added support for tracking custom ...
GitHub user kalpit opened a pull request: https://github.com/apache/spark/pull/918 SPARK-1972: Added support for tracking custom task-related metrics Any piece of Spark machinery that cares to track custom task-related metrics can now use the setCustomMetric(name,value) method on TaskMetrics to do that. The StagePage in UI now shows Custom Metrics for every task. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kalpit/spark topic/customTaskMetrics Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/918.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #918 commit 0d96d95a08fc87592827e4e05222ec89f6c832fb Author: Kalpit Shah shahkalpi...@gmail.com Date: 2014-05-30T09:04:49Z SPARK-1972: Added support for tracking custom task-related metrics Any piece of Spark machinery that cares to track custom task-related metrics can now use the setCustomMetric(name,value) method on TaskMetrics to do that. The StagePage in UI now shows Custom Metrics for every task. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1972: Added support for tracking custom ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/918#issuecomment-44629724 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
