[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2018-07-24 Thread heary-cao
Github user heary-cao closed the pull request at: https://github.com/apache/spark/pull/18555 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2018-02-05 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r166171819 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -231,6 +315,9 @@ package object config { private[spark] val

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2018-02-05 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r166164886 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -231,6 +315,9 @@ package object config { private[spark] val

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2018-02-05 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r166164325 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -231,6 +315,9 @@ package object config { private[spark] val

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2018-02-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r165838720 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -231,6 +315,9 @@ package object config { private[spark] val

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r129946652 --- Diff: core/src/test/scala/org/apache/spark/SparkConfSuite.scala --- @@ -322,6 +324,291 @@ class SparkConfSuite extends SparkFunSuite with

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-11 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126660503 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -51,29 +62,65 @@ package object config {

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-11 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126660036 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -51,29 +62,65 @@ package object config {

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126614860 --- Diff: docs/configuration.md --- @@ -142,7 +142,7 @@ of the most common options to set are: 1g Amount of memory to use for the

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-10 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126343554 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -51,29 +62,61 @@ package object config {

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126329361 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -51,29 +63,66 @@ package object config {

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126329304 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -51,29 +62,61 @@ package object config {

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126329325 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -51,29 +62,61 @@ package object config {

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-09 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126326738 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -51,29 +62,61 @@ package object config {

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126315874 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -327,6 +421,8 @@ package object config { .doc("The

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126315869 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -306,19 +396,23 @@ package object config { "record

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126315870 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -306,19 +396,23 @@ package object config { "record

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126315864 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -306,19 +396,23 @@ package object config { "record

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126315856 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -259,6 +344,7 @@ package object config { " over

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126315844 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -183,32 +254,42 @@ package object config {

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126315840 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -175,6 +244,8 @@ package object config {

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126315850 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -251,6 +335,7 @@ package object config { private[spark]

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126315834 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -51,29 +62,61 @@ package object config {

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126315664 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -51,29 +62,61 @@ package object config {

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126315636 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -51,29 +62,61 @@ package object config {

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126315617 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -35,10 +35,21 @@ package object config {

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-09 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126308305 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -51,29 +63,66 @@ package object config {

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-09 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126308228 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -35,10 +35,21 @@ package object config {

[GitHub] spark pull request #18555: [SPARK-21353][CORE]add checkValue in spark.intern...

2017-07-09 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126308199 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -51,29 +62,63 @@ package object config {