[GitHub] [spark] maropu commented on pull request #28852: [SPARK-30616][SQL] Introduce TTL config option for SQL Metadata Cache
maropu commented on pull request #28852: URL: https://github.com/apache/spark/pull/28852#issuecomment-652118658 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on pull request #28852: [SPARK-30616][SQL] Introduce TTL config option for SQL Metadata Cache
maropu commented on pull request #28852: URL: https://github.com/apache/spark/pull/28852#issuecomment-652100058 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on pull request #28852: [SPARK-30616][SQL] Introduce TTL config option for SQL Metadata Cache
maropu commented on pull request #28852: URL: https://github.com/apache/spark/pull/28852#issuecomment-651635382 Looks okay. cc: @cloud-fan @dongjoon-hyun @HyukjinKwon This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on pull request #28852: [SPARK-30616][SQL] Introduce TTL config option for SQL Metadata Cache
maropu commented on pull request #28852: URL: https://github.com/apache/spark/pull/28852#issuecomment-646467472 > Do you think I should create a new suite for FileStatusCache? Or try to extend HiveSchemaInferenceSuite? How about adding `CatalogFileIndexSuite` in the hive package? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on pull request #28852: [SPARK-30616][SQL] Introduce TTL config option for SQL Metadata Cache
maropu commented on pull request #28852: URL: https://github.com/apache/spark/pull/28852#issuecomment-645696202 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on pull request #28852: [SPARK-30616][SQL] Introduce TTL config option for SQL Metadata Cache
maropu commented on pull request #28852: URL: https://github.com/apache/spark/pull/28852#issuecomment-645696318 Could you add tests? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
