[GitHub] [spark] AnywalkerGiser commented on pull request #36566: [SPARK-39176][PYSPARK] Fixed a problem with pyspark serializing pre-1970 datetime in windows

2022-05-16 Thread GitBox


AnywalkerGiser commented on PR #36566:
URL: https://github.com/apache/spark/pull/36566#issuecomment-1128444516

   I thought it was a bug in python, but the documentation said it would report 
an error if it was out of time range. I tested python 3.6, 3.7, and 3.8 on 
windows.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AnywalkerGiser commented on pull request #36566: [SPARK-39176][PYSPARK] Fixed a problem with pyspark serializing pre-1970 datetime in windows

2022-05-16 Thread GitBox


AnywalkerGiser commented on PR #36566:
URL: https://github.com/apache/spark/pull/36566#issuecomment-1128436320

   I think the Spark project can look for a solution if Python doesn't fix this 
bug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AnywalkerGiser commented on pull request #36566: [SPARK-39176][PYSPARK] Fixed a problem with pyspark serializing pre-1970 datetime in windows

2022-05-16 Thread GitBox


AnywalkerGiser commented on PR #36566:
URL: https://github.com/apache/spark/pull/36566#issuecomment-1128434671

   Here are some blogs on related issues:
   [Python | mktime overflow 
error](https://stackoverflow.com/questions/2518706/python-mktime-overflow-error)
   [Python fromtimestamp 
OSError](https://stackoverflow.com/questions/37494983/python-fromtimestamp-oserror)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AnywalkerGiser commented on pull request #36566: [SPARK-39176][PYSPARK] Fixed a problem with pyspark serializing pre-1970 datetime in windows

2022-05-16 Thread GitBox


AnywalkerGiser commented on PR #36566:
URL: https://github.com/apache/spark/pull/36566#issuecomment-1128422483

   Understood, looking forward to your reply later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AnywalkerGiser commented on pull request #36566: [SPARK-39176][PYSPARK] Fixed a problem with pyspark serializing pre-1970 datetime in windows

2022-05-16 Thread GitBox


AnywalkerGiser commented on PR #36566:
URL: https://github.com/apache/spark/pull/36566#issuecomment-1128391633

   @HyukjinKwon Can this solution be merged into master?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AnywalkerGiser commented on pull request #36566: [SPARK-39176][PYSPARK] Fixed a problem with pyspark serializing pre-1970 datetime in windows

2022-05-16 Thread GitBox


AnywalkerGiser commented on PR #36566:
URL: https://github.com/apache/spark/pull/36566#issuecomment-1128391117

   The localtime function does not differ in OS, the fromtimestamp function 
does, and datetime many functions have problems resolving dates before 1970 in 
windows.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AnywalkerGiser commented on pull request #36566: [SPARK-39176][PYSPARK] Fixed a problem with pyspark serializing pre-1970 datetime in windows

2022-05-16 Thread GitBox


AnywalkerGiser commented on PR #36566:
URL: https://github.com/apache/spark/pull/36566#issuecomment-1128378813

   @HyukjinKwon [Python3 datetime interface 
documentation](https://docs.python.org/3/library/datetime.html)
   This is explained in this document.
   
![image](https://user-images.githubusercontent.com/97273184/168725090-9f9b5320-50d2-46d0-acb0-8bb4a73d2694.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AnywalkerGiser commented on pull request #36566: [SPARK-39176][PYSPARK] Fixed a problem with pyspark serializing pre-1970 datetime in windows

2022-05-16 Thread GitBox


AnywalkerGiser commented on PR #36566:
URL: https://github.com/apache/spark/pull/36566#issuecomment-1128370730

   @HyukjinKwon Do you mean the platform library, added to the code comments?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AnywalkerGiser commented on pull request #36566: [SPARK-39176][PYSPARK] Fixed a problem with pyspark serializing pre-1970 datetime in windows

2022-05-16 Thread GitBox


AnywalkerGiser commented on PR #36566:
URL: https://github.com/apache/spark/pull/36566#issuecomment-1127516999

   @HyukjinKwon I closed the RP in the 3.0 
branch(https://github.com/apache/spark/pull/36537) and raised a new RP in the 
master branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org