[GitHub] [spark] EnricoMi commented on a diff in pull request #37304: [SPARK-39877][PySpark] Add unpivot to PySpark DataFrame API

2022-07-29 Thread GitBox
EnricoMi commented on code in PR #37304: URL: https://github.com/apache/spark/pull/37304#discussion_r932977680 ## sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala: ## @@ -2127,6 +2127,15 @@ class Dataset[T] private[sql]( valueColumnName: String): DataFrame =

[GitHub] [spark] EnricoMi commented on a diff in pull request #37304: [SPARK-39877][PySpark] Add unpivot to PySpark DataFrame API

2022-07-29 Thread GitBox
EnricoMi commented on code in PR #37304: URL: https://github.com/apache/spark/pull/37304#discussion_r932976862 ## python/pyspark/context.py: ## @@ -309,10 +309,7 @@ def _do_init( if sys.version_info[:2] < (3, 8): with warnings.catch_warnings():

[GitHub] [spark] EnricoMi commented on a diff in pull request #37304: [SPARK-39877][PySpark] Add unpivot to PySpark DataFrame API

2022-07-28 Thread GitBox
EnricoMi commented on code in PR #37304: URL: https://github.com/apache/spark/pull/37304#discussion_r932044028 ## python/pyspark/sql/dataframe.py: ## @@ -2188,6 +2188,142 @@ def cube(self, *cols: "ColumnOrName") -> "GroupedData": # type: ignore[misc] return

[GitHub] [spark] EnricoMi commented on a diff in pull request #37304: [SPARK-39877][PySpark] Add unpivot to PySpark DataFrame API

2022-07-28 Thread GitBox
EnricoMi commented on code in PR #37304: URL: https://github.com/apache/spark/pull/37304#discussion_r931873169 ## sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala: ## @@ -2127,6 +2127,15 @@ class Dataset[T] private[sql]( valueColumnName: String): DataFrame =

[GitHub] [spark] EnricoMi commented on a diff in pull request #37304: [SPARK-39877][PySpark] Add unpivot to PySpark DataFrame API

2022-07-27 Thread GitBox
EnricoMi commented on code in PR #37304: URL: https://github.com/apache/spark/pull/37304#discussion_r930982032 ## python/pyspark/sql/dataframe.py: ## @@ -2188,6 +2188,142 @@ def cube(self, *cols: "ColumnOrName") -> "GroupedData": # type: ignore[misc] return

[GitHub] [spark] EnricoMi commented on a diff in pull request #37304: [SPARK-39877][PySpark] Add unpivot to PySpark DataFrame API

2022-07-27 Thread GitBox
EnricoMi commented on code in PR #37304: URL: https://github.com/apache/spark/pull/37304#discussion_r930979982 ## python/pyspark/sql/dataframe.py: ## @@ -2188,6 +2188,142 @@ def cube(self, *cols: "ColumnOrName") -> "GroupedData": # type: ignore[misc] return

[GitHub] [spark] EnricoMi commented on a diff in pull request #37304: [SPARK-39877][PySpark] Add unpivot to PySpark DataFrame API

2022-07-27 Thread GitBox
EnricoMi commented on code in PR #37304: URL: https://github.com/apache/spark/pull/37304#discussion_r930781960 ## sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala: ## @@ -2127,6 +2127,15 @@ class Dataset[T] private[sql]( valueColumnName: String): DataFrame =

[GitHub] [spark] EnricoMi commented on a diff in pull request #37304: [SPARK-39877][PySpark] Add unpivot to PySpark DataFrame API

2022-07-27 Thread GitBox
EnricoMi commented on code in PR #37304: URL: https://github.com/apache/spark/pull/37304#discussion_r930678850 ## sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala: ## @@ -2127,6 +2127,15 @@ class Dataset[T] private[sql]( valueColumnName: String): DataFrame =