Gschiavon commented on issue #25728: [SPARK-29020][SQL] Improving array_sort
behaviour
URL: https://github.com/apache/spark/pull/25728#issuecomment-554776903
No problem @kiszk ! I just made some changes based on your comments!
Gschiavon commented on issue #25728: [SPARK-29020][SQL] Improving array_sort
behaviour
URL: https://github.com/apache/spark/pull/25728#issuecomment-554749156
ping @kiszk
This is an automated message from the Apache Git
Gschiavon commented on issue #25728: [SPARK-29020][SQL] Improving array_sort
behaviour
URL: https://github.com/apache/spark/pull/25728#issuecomment-531099338
I understood the same @ueshin since he said to match presto
This
Gschiavon commented on issue #25728: [SPARK-29020][SQL] Improving array_sort
behaviour
URL: https://github.com/apache/spark/pull/25728#issuecomment-530767308
Ok I understand. Also I think that might be a different PR? and then have
different signatures for array_sort. For example:
Gschiavon commented on issue #25728: [SPARK-29020][SQL] Improving array_sort
behaviour
URL: https://github.com/apache/spark/pull/25728#issuecomment-530207202
How does it translate for this PR @ueshin ?
This is an automated
Gschiavon commented on issue #25728: [SPARK-29020][SQL] Improving array_sort
behaviour
URL: https://github.com/apache/spark/pull/25728#issuecomment-530031571
I think it would be good to have array_sort to be able to order in both
ways, all the array function from 2.4.0 are
Gschiavon commented on issue #25728: [SPARK-29020][SQL] Improving array_sort
behaviour
URL: https://github.com/apache/spark/pull/25728#issuecomment-529994076
> I see, is it that the ordering of nulls is different?
> I think we'd at least want the doc of each to comment on the difference
Gschiavon commented on issue #25728: [SPARK-29020][SQL] Improving array_sort
behaviour
URL: https://github.com/apache/spark/pull/25728#issuecomment-529977320
> @ueshin yeah I agree, the bigger question is, why do we have both
`array_sort` and `sort_array`?
>
> @kiszk looks like you
Gschiavon commented on issue #25728: [SPARK-29020][SQL] Improving array_sort
behaviour
URL: https://github.com/apache/spark/pull/25728#issuecomment-529976886
@srowen we couldn't make an alias between `sort_array` and `array_sort`
because they don't have the same null policy, it would
