[GitHub] [spark] GuoPhilipse commented on pull request #29056: [SPARK-31753][SQL][DOCS] Add missing keywords in the SQL docs
GuoPhilipse commented on pull request #29056: URL: https://github.com/apache/spark/pull/29056#issuecomment-661863407 > @GuoPhilipse Could you generate HTML docs and check if all things are okay for this udpate? > In most PRs for doc updates, the screenshots of HTML docs are often attached in the PR description, e.g., #28672 will append later This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] GuoPhilipse commented on pull request #29056: [SPARK-31753][SQL][DOCS] Add missing keywords in the SQL docs
GuoPhilipse commented on pull request #29056: URL: https://github.com/apache/spark/pull/29056#issuecomment-661820472 > @GuoPhilipse Btw, we still have more document improvement issues; > > 1. Improve the structure of auto-generated built-in function pages in SQL references, https://issues.apache.org/jira/browse/SPARK-31513 > 2. Add `group` tags (`ExpressionDescription`) to all the built-in functions: (Related JIRA: https://issues.apache.org/jira/browse/SPARK-31429) > > As you know, we currently have the two duplicated document pages for built-in functions; > > * https://spark.apache.org/docs/latest/api/sql/index.html > * https://spark.apache.org/docs/latest/sql-ref-functions.html#built-in-functions > > If we finish adding the tags, we might be able to remove the former page. If you're interested in more contributions, feel free to take them over. Its very helpful. cc: @HyukjinKwon @huaxingao Thanks @maropu , will glad to take more look on this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] GuoPhilipse commented on pull request #29056: [SPARK-31753][SQL][DOCS] Add missing keywords in the SQL docs
GuoPhilipse commented on pull request #29056: URL: https://github.com/apache/spark/pull/29056#issuecomment-661817473 S > @GuoPhilipse Could you generate HTML docs and check if all things are okay for this udpate? > In most PRs for doc updates, the screenshots of HTML docs are often attached in the PR description, e.g., #28672 emmm. I did not find a entrance for generate HTML docs, do we have guide for this ？ do you have ideas? @maropu @huaxingao This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] GuoPhilipse commented on pull request #29056: [SPARK-31753][SQL][DOCS] Add missing keywords in the SQL docs
GuoPhilipse commented on pull request #29056: URL: https://github.com/apache/spark/pull/29056#issuecomment-660646194 Thanks @maropu @huaxingao, really appreciated by your earnest and carefull review. I have leant a lot from this PR. Thanks for your time. BTW @maropu do you have any new comments? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] GuoPhilipse commented on pull request #29056: [SPARK-31753][SQL][DOCS] Add missing keywords in the SQL docs
GuoPhilipse commented on pull request #29056: URL: https://github.com/apache/spark/pull/29056#issuecomment-660127307 > btw, could you update the PR description, too? e.g., remove `FROM` sure ,wil update soon. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] GuoPhilipse commented on pull request #29056: [SPARK-31753][SQL][DOCS] Add missing keywords in the SQL docs
GuoPhilipse commented on pull request #29056: URL: https://github.com/apache/spark/pull/29056#issuecomment-659456012 Thanks @huaxingao @maropu .have updated the suggestion . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] GuoPhilipse commented on pull request #29056: [SPARK-31753][SQL][DOCS] Add missing keywords in the SQL docs
GuoPhilipse commented on pull request #29056: URL: https://github.com/apache/spark/pull/29056#issuecomment-657942650 cc @maropu This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
