[GitHub] [spark] HeartSaVioR commented on issue #25407: [SPARK-28650][SS][DOC] Correct explanation of guarantee for ForeachWriter
HeartSaVioR commented on issue #25407: [SPARK-28650][SS][DOC] Correct explanation of guarantee for ForeachWriter URL: https://github.com/apache/spark/pull/25407#issuecomment-522919791 Thanks for the quick review and merge! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #25407: [SPARK-28650][SS][DOC] Correct explanation of guarantee for ForeachWriter
HeartSaVioR commented on issue #25407: [SPARK-28650][SS][DOC] Correct explanation of guarantee for ForeachWriter URL: https://github.com/apache/spark/pull/25407#issuecomment-521898420 @zsxwing kindly reminder. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #25407: [SPARK-28650][SS][DOC] Correct explanation of guarantee for ForeachWriter
HeartSaVioR commented on issue #25407: [SPARK-28650][SS][DOC] Correct explanation of guarantee for ForeachWriter URL: https://github.com/apache/spark/pull/25407#issuecomment-520737809 I guess I addressed all review comments. Could we please take another round of reviews? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #25407: [SPARK-28650][SS][DOC] Correct explanation of guarantee for ForeachWriter
HeartSaVioR commented on issue #25407: [SPARK-28650][SS][DOC] Correct explanation of guarantee for ForeachWriter URL: https://github.com/apache/spark/pull/25407#issuecomment-520264633 I guess it's not only applied to Spark 3.0 but applied to all the versions. (may worth to port back) End users may need to be noticed even they don't upgrade their Spark version, as they need to revisit their implementation of ForeachWriter. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #25407: [SPARK-28650][SS][DOC] Correct explanation of guarantee for ForeachWriter
HeartSaVioR commented on issue #25407: [SPARK-28650][SS][DOC] Correct explanation of guarantee for ForeachWriter URL: https://github.com/apache/spark/pull/25407#issuecomment-520263670 > Yes, sounds like the docs need an update. Is there any place in the user docs that this kind of gotcha should be documented? Or is it too niche? I found same explanation is placed in structured streaming guide doc - I'll modify it as well. I'd emphasize this (release note, etc.) as this is changing the guarantee and end users may have to change their implementation of ForeachWriter. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
