[GitHub] [spark] HeartSaVioR commented on pull request #28377: [SPARK-27340][SS][2.4] Alias on TimeWindow expression may cause watermark metadata lost

2020-04-27 Thread GitBox
HeartSaVioR commented on pull request #28377: URL: https://github.com/apache/spark/pull/28377#issuecomment-620314357 That said, I'd support porting back this to 2.4 as it fixes the wrong code. This change might impact broader audiences (so technically saying the PR/commit title doesn't rep

[GitHub] [spark] HeartSaVioR commented on pull request #28377: [SPARK-27340][SS][2.4] Alias on TimeWindow expression may cause watermark metadata lost

2020-04-27 Thread GitBox
HeartSaVioR commented on pull request #28377: URL: https://github.com/apache/spark/pull/28377#issuecomment-620309415 > It sounds like the metadata is not available for TimeWindow expression when the function name(alias: String) copies the metadata to explicitMetadata. Thus, we do not set i