HeartSaVioR edited a comment on pull request #28026: URL: https://github.com/apache/spark/pull/28026#issuecomment-620244166
Simply thinking as user perspective, if we still support `EXTERNAL` keyword on creating table syntax then end users will try to execute the same query they do with Hive, and be questioned if it behaves differently. That's the main reason I proposed adding marker to "differentiate" the twos (opposite to the direction of this maybe), clearly indicating which space (Spark, or Hive compatible) they're in to execute the query. This is a debt on starting with Hive compatible DDL - Spark has been putting the great efforts on compatibility with Hive and attracts Hive users to migrate to Spark, but this also leads to misunderstand of end users Spark SQL should be compatible with Hive in any way. I don't think the unified create table syntax should cover all possible clauses on both Spark native and Hive, especially Hive side. This is a new start and we're not forced to guarantee compatibility with Hive. That might bring backward incompatibility, but this can be tolerated if we no longer want to treat Hive compatibility as the first class. (End users could still deal with beeline or so.) If then I think we should also make clear to the points we drop support - if we want to drop support of something then it should be clearly represented in syntax perspective, in this case, get rid of `EXTERNAL` keyword. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
