[GitHub] [spark] Hisoka-X commented on pull request #41156: [SPARK-40129][SQL] Fix Decimal multiply can produce the wrong answer

2023-08-01 Thread via GitHub
Hisoka-X commented on PR #41156: URL: https://github.com/apache/spark/pull/41156#issuecomment-1660424748 > Is it better to avoid double round-up? e.g. we can pass a `MathContext` of the result decimal type (with wider precision to avoid overflow) to all decimal arithmetic operations.

[GitHub] [spark] Hisoka-X commented on pull request #41156: [SPARK-40129][SQL] Fix Decimal multiply can produce the wrong answer

2023-08-01 Thread via GitHub
Hisoka-X commented on PR #41156: URL: https://github.com/apache/spark/pull/41156#issuecomment-1660351326 MySQL: ![image](https://github.com/apache/spark/assets/32387433/3cfdfbf2-4354-4d7e-b046-5361493f5e42) MySQL round 6:

[GitHub] [spark] Hisoka-X commented on pull request #41156: [SPARK-40129][SQL] Fix Decimal multiply can produce the wrong answer

2023-05-19 Thread via GitHub
Hisoka-X commented on PR #41156: URL: https://github.com/apache/spark/pull/41156#issuecomment-1554096090 cc @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To