[GitHub] [spark] HyukjinKwon commented on a change in pull request #22921: [SPARK-25908][CORE][SQL] Remove old deprecated items in Spark 3
HyukjinKwon commented on a change in pull request #22921:
[SPARK-25908][CORE][SQL] Remove old deprecated items in Spark 3
URL: https://github.com/apache/spark/pull/22921#discussion_r384303852
##
File path: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala
##
@@ -281,9 +265,6 @@ class GeneralMLWriter(stage: PipelineStage) extends
MLWriter with Logging {
// override for Java compatibility
override def session(sparkSession: SparkSession): this.type =
super.session(sparkSession)
-
- // override for Java compatibility
- override def context(sqlContext: SQLContext): this.type =
super.session(sqlContext.sparkSession)
Review comment:
This seems properly deprecated in `MLWriter` as its parent.
https://spark.apache.org/docs/latest/api/scala/index.html#org.apache.spark.ml.util.GeneralMLWriter@context(sqlContext:org.apache.spark.sql.SQLContext):GeneralMLWriter.this.type
and the Scaladoc explicitly shows this at `GeneralMLWriter` too. Seems right
to remove together if we should in `MLWriter`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #22921: [SPARK-25908][CORE][SQL] Remove old deprecated items in Spark 3
HyukjinKwon commented on a change in pull request #22921:
[SPARK-25908][CORE][SQL] Remove old deprecated items in Spark 3
URL: https://github.com/apache/spark/pull/22921#discussion_r384303852
##
File path: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala
##
@@ -281,9 +265,6 @@ class GeneralMLWriter(stage: PipelineStage) extends
MLWriter with Logging {
// override for Java compatibility
override def session(sparkSession: SparkSession): this.type =
super.session(sparkSession)
-
- // override for Java compatibility
- override def context(sqlContext: SQLContext): this.type =
super.session(sqlContext.sparkSession)
Review comment:
This seems properly deprecated in `MLWriter` as its parent.
https://spark.apache.org/docs/latest/api/scala/index.html#org.apache.spark.ml.util.GeneralMLWriter@context(sqlContext:org.apache.spark.sql.SQLContext):GeneralMLWriter.this.type
and the Scaladoc explicitly shows this too. Seems right to remove together
if we should in `MLWriter`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #22921: [SPARK-25908][CORE][SQL] Remove old deprecated items in Spark 3
HyukjinKwon commented on a change in pull request #22921:
[SPARK-25908][CORE][SQL] Remove old deprecated items in Spark 3
URL: https://github.com/apache/spark/pull/22921#discussion_r384303852
##
File path: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala
##
@@ -281,9 +265,6 @@ class GeneralMLWriter(stage: PipelineStage) extends
MLWriter with Logging {
// override for Java compatibility
override def session(sparkSession: SparkSession): this.type =
super.session(sparkSession)
-
- // override for Java compatibility
- override def context(sqlContext: SQLContext): this.type =
super.session(sqlContext.sparkSession)
Review comment:
This seems properly deprecated in `MLWriter` as its parent.
and the Scaladoc explicitly shows this too. Seems right to remove together
if we should in `MLWriter`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
