[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39123: [SPARK-41583][CONNECT][PROTOBUF] Add Spark Connect and protobuf into setup.py with specifying dependencies

2022-12-19 Thread GitBox


HyukjinKwon commented on code in PR #39123:
URL: https://github.com/apache/spark/pull/39123#discussion_r1052742314


##
python/setup.py:
##
@@ -113,6 +113,7 @@ def _supports_symlinks():
 # Also don't forget to update python/docs/source/getting_started/install.rst.
 _minimum_pandas_version = "1.0.5"
 _minimum_pyarrow_version = "1.0.0"
+_minimum_pandas_version = "1.48.1"

Review Comment:
   ```suggestion
   _minimum_grpc_version = "1.48.1"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39123: [SPARK-41583][CONNECT][PROTOBUF] Add Spark Connect and protobuf into setup.py with specifying dependencies

2022-12-18 Thread GitBox


HyukjinKwon commented on code in PR #39123:
URL: https://github.com/apache/spark/pull/39123#discussion_r1051869903


##
python/docs/source/getting_started/install.rst:
##
@@ -50,6 +50,8 @@ If you want to install extra dependencies for a specific 
component, you can inst
 pip install pyspark[sql]
 # pandas API on Spark
 pip install pyspark[pandas_on_spark] plotly  # to plot your data, you can 
install plotly together.
+# Spark Connect
+pip install pyspark[connect]

Review Comment:
   This will be fixed soon.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org