[GitHub] [spark] HyukjinKwon commented on issue #24752: [SPARK-27893][SQL][PYTHON] Create an integrated test base for Python, Scalar Pandas, Scala UDF by sql files

2019-06-02 Thread GitBox
HyukjinKwon commented on issue #24752: [SPARK-27893][SQL][PYTHON] Create an integrated test base for Python, Scalar Pandas, Scala UDF by sql files URL: https://github.com/apache/spark/pull/24752#issuecomment-498081778 Let me open a umbrella JIRA to add UDF specific tests based on this test

[GitHub] [spark] HyukjinKwon commented on issue #24752: [SPARK-27893][SQL][PYTHON] Create an integrated test base for Python, Scalar Pandas, Scala UDF by sql files

2019-06-02 Thread GitBox
HyukjinKwon commented on issue #24752: [SPARK-27893][SQL][PYTHON] Create an integrated test base for Python, Scalar Pandas, Scala UDF by sql files URL: https://github.com/apache/spark/pull/24752#issuecomment-498081543 The last changes are comment-only. Im merging this based upon positive

[GitHub] [spark] HyukjinKwon commented on issue #24752: [SPARK-27893][SQL][PYTHON] Create an integrated test base for Python, Scalar Pandas, Scala UDF by sql files

2019-05-31 Thread GitBox
HyukjinKwon commented on issue #24752: [SPARK-27893][SQL][PYTHON] Create an integrated test base for Python, Scalar Pandas, Scala UDF by sql files URL: https://github.com/apache/spark/pull/24752#issuecomment-497907209 I believe I addressed all comments and it's ready for a review.

[GitHub] [spark] HyukjinKwon commented on issue #24752: [SPARK-27893][SQL][PYTHON] Create an integrated test base for Python, Scalar Pandas, Scala UDF by sql files

2019-05-31 Thread GitBox
HyukjinKwon commented on issue #24752: [SPARK-27893][SQL][PYTHON] Create an integrated test base for Python, Scalar Pandas, Scala UDF by sql files URL: https://github.com/apache/spark/pull/24752#issuecomment-497727508 k, seems running fine: ``` [info] - udf/udf-inner-join.sql -

[GitHub] [spark] HyukjinKwon commented on issue #24752: [SPARK-27893][SQL][PYTHON] Create an integrated test base for Python, Scalar Pandas, Scala UDF by sql files

2019-05-31 Thread GitBox
HyukjinKwon commented on issue #24752: [SPARK-27893][SQL][PYTHON] Create an integrated test base for Python, Scalar Pandas, Scala UDF by sql files URL: https://github.com/apache/spark/pull/24752#issuecomment-497713174 Let me address the comments and clean up more tomorrow.

[GitHub] [spark] HyukjinKwon commented on issue #24752: [SPARK-27893][SQL][PYTHON] Create an integrated test base for Python, Scalar Pandas, Scala UDF by sql files

2019-05-31 Thread GitBox
HyukjinKwon commented on issue #24752: [SPARK-27893][SQL][PYTHON] Create an integrated test base for Python, Scalar Pandas, Scala UDF by sql files URL: https://github.com/apache/spark/pull/24752#issuecomment-497594781 Yea, we hit once before (IIRC). Both should be separate but some places

[GitHub] [spark] HyukjinKwon commented on issue #24752: [SPARK-27893][SQL][PYTHON] Create an integrated test base for Python, Scalar Pandas, Scala UDF by sql files

2019-05-30 Thread GitBox
HyukjinKwon commented on issue #24752: [SPARK-27893][SQL][PYTHON] Create an integrated test base for Python, Scalar Pandas, Scala UDF by sql files URL: https://github.com/apache/spark/pull/24752#issuecomment-497579209 cc @BryanCutler, @cloud-fan, @icexelloss, @viirya, @gatorsmile, @ueshin,