[GitHub] [spark] HyukjinKwon commented on issue #27861: [SPARK-30707][SQL]Window function set partitionSpec as order spec when orderSpec is empty

2020-04-22 Thread GitBox


HyukjinKwon commented on issue #27861:
URL: https://github.com/apache/spark/pull/27861#issuecomment-618128508


   I think he wants to use the partition column as the ordering column 
implicitly, instead of not specifying it - 
https://github.com/apache/spark/pull/27861/files#diff-9847f5cef7cf7fbc5830fbc6b779ee10R1702.
 It wouldn't work if the ordering is not specified per 
https://github.com/apache/spark/blob/a28ed86a387b286745b30cd4d90b3d558205a5a7/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L2773-L2776
 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on issue #27861: [SPARK-30707][SQL]Window function set partitionSpec as order spec when orderSpec is empty

2020-04-22 Thread GitBox


HyukjinKwon commented on issue #27861:
URL: https://github.com/apache/spark/pull/27861#issuecomment-617764393


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on issue #27861: [SPARK-30707][SQL]Window function set partitionSpec as order spec when orderSpec is empty

2020-03-24 Thread GitBox
HyukjinKwon commented on issue #27861: [SPARK-30707][SQL]Window function set 
partitionSpec as order spec when orderSpec is empty
URL: https://github.com/apache/spark/pull/27861#issuecomment-603638120
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on issue #27861: [SPARK-30707][SQL]Window function set partitionSpec as order spec when orderSpec is empty

2020-03-22 Thread GitBox
HyukjinKwon commented on issue #27861: [SPARK-30707][SQL]Window function set 
partitionSpec as order spec when orderSpec is empty
URL: https://github.com/apache/spark/pull/27861#issuecomment-602330738
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on issue #27861: [SPARK-30707][SQL]Window function set partitionSpec as order spec when orderSpec is empty

2020-03-10 Thread GitBox
HyukjinKwon commented on issue #27861: [SPARK-30707][SQL]Window function set 
partitionSpec as order spec when orderSpec is empty
URL: https://github.com/apache/spark/pull/27861#issuecomment-597391038
 
 
   This seems already supported in other language APIs too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on issue #27861: [SPARK-30707][SQL]Window function set partitionSpec as order spec when orderSpec is empty

2020-03-10 Thread GitBox
HyukjinKwon commented on issue #27861: [SPARK-30707][SQL]Window function set 
partitionSpec as order spec when orderSpec is empty
URL: https://github.com/apache/spark/pull/27861#issuecomment-597391066
 
 
   cc @hvanhovell 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on issue #27861: [SPARK-30707][SQL]Window function set partitionSpec as order spec when orderSpec is empty

2020-03-10 Thread GitBox
HyukjinKwon commented on issue #27861: [SPARK-30707][SQL]Window function set 
partitionSpec as order spec when orderSpec is empty
URL: https://github.com/apache/spark/pull/27861#issuecomment-597389726
 
 
   ok to test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org