[GitHub] [spark] HyukjinKwon commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype
HyukjinKwon commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-655298519 Thanks guys, sure. I will make a followup. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype
HyukjinKwon commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-655278572 If we're going to treat `void` as Hive legacy, let's don't support it at all and make the direction to deprecate and remove `NullType` away. If we'll still care and have `NullType`, let's make it a proper type in Spark. If we're not sure, let's don't change `simpleString` to something else for now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype
HyukjinKwon commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-655277714 Re: https://github.com/apache/spark/pull/28833#discussion_r448165084 Sorry I read the comments just now. So the decision here is we allow to parse `void` as `NullType` but doesn't allow it in some commands like `CREATE TABLE`s. How about other cases when we directly use DDL-formatted string as its type? These simple type strings can be used in many places such as `from_csv`, `from_json`, `createDataFrame`, etc. However, `StructType.simpleString` cannot still be parsed as the valid types. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
