[GitHub] [spark] HyukjinKwon commented on pull request #35200: [SPARK-37903][PYTHON] Replace string_typehints with get_type_hints

2022-01-17 Thread GitBox
HyukjinKwon commented on pull request #35200: URL: https://github.com/apache/spark/pull/35200#issuecomment-1015006891 oh, okay, `max` doesn't have a return type hint. we should raise an exception -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [spark] HyukjinKwon commented on pull request #35200: [SPARK-37903][PYTHON] Replace string_typehints with get_type_hints

2022-01-17 Thread GitBox
HyukjinKwon commented on pull request #35200: URL: https://github.com/apache/spark/pull/35200#issuecomment-1015006329 I think it's correct to infer the type from `max`. does it cause any problem? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [spark] HyukjinKwon commented on pull request #35200: [SPARK-37903][PYTHON] Replace string_typehints with get_type_hints

2022-01-13 Thread GitBox
HyukjinKwon commented on pull request #35200: URL: https://github.com/apache/spark/pull/35200#issuecomment-1012660871 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif