[GitHub] [spark] StefanXiepj commented on pull request #29144: [SPARK-15118][SQL] Spark SQLConf should support loading hive properties in hive-site.xml

2020-07-17 Thread GitBox


StefanXiepj commented on pull request #29144:
URL: https://github.com/apache/spark/pull/29144#issuecomment-660421270


   > #24489 has addressed your major concern. For the other conf, we can 
discuss it case by case. In general, we are not respecting Hive conf.
   
   @gatorsmile This pr will  be closed, thanks very much for taking the time to 
review.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] StefanXiepj commented on pull request #29144: [SPARK-15118][SQL] Spark SQLConf should support loading hive properties in hive-site.xml

2020-07-17 Thread GitBox


StefanXiepj commented on pull request #29144:
URL: https://github.com/apache/spark/pull/29144#issuecomment-660412941


   hi @maropu ,
   
   Could you please take a look at this and give some advice? Thx.
   
   Jeff.r



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org