[GitHub] [spark] WangGuangxin commented on a change in pull request #28780: [SPARK-31952][SQL]Fix incorrect memory spill metric when doing Aggregate

2020-06-22 Thread GitBox
WangGuangxin commented on a change in pull request #28780: URL: https://github.com/apache/spark/pull/28780#discussion_r443451092 ## File path: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java ## @@ -104,11 +104,13 @@ public static

[GitHub] [spark] WangGuangxin commented on a change in pull request #28780: [SPARK-31952][SQL]Fix incorrect memory spill metric when doing Aggregate

2020-06-22 Thread GitBox
WangGuangxin commented on a change in pull request #28780: URL: https://github.com/apache/spark/pull/28780#discussion_r443445290 ## File path: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java ## @@ -104,11 +104,13 @@ public static

[GitHub] [spark] WangGuangxin commented on a change in pull request #28780: [SPARK-31952][SQL]Fix incorrect memory spill metric when doing Aggregate

2020-06-15 Thread GitBox
WangGuangxin commented on a change in pull request #28780: URL: https://github.com/apache/spark/pull/28780#discussion_r440108353 ## File path: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java ## @@ -104,11 +104,13 @@ public static

[GitHub] [spark] WangGuangxin commented on a change in pull request #28780: [SPARK-31952][SQL]Fix incorrect memory spill metric when doing Aggregate

2020-06-10 Thread GitBox
WangGuangxin commented on a change in pull request #28780: URL: https://github.com/apache/spark/pull/28780#discussion_r438076494 ## File path: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java ## @@ -104,11 +104,13 @@ public static