Yikun commented on code in PR #37328:
URL: https://github.com/apache/spark/pull/37328#discussion_r932814726
##########
python/pyspark/pandas/series.py:
##########
@@ -6322,13 +6322,21 @@ def argmax(self, axis: Axis = None, skipna: bool =
True) -> int:
# If the maximum is achieved in multiple locations, the first row
position is returned.
return -1 if max_value[0] is None else max_value[1]
- def argmin(self) -> int:
+ def argmin(self, axis: Axis = None, skipna: bool = True) -> int:
"""
Return int position of the smallest value in the Series.
If the minimum is achieved in multiple locations,
the first row position is returned.
+ Parameters
+ ----------
+ axis : {{None}}
+ Dummy argument for consistency with Series.
+ skipna : bool, default True
+ Exclude NA/null values. If the entire Series is NA, the result
Review Comment:
> If the entire Series is NA, the result
It seems a plus doc for pandas (1.4.3), do we want to add a test for this?
[1] https://pandas.pydata.org/docs/reference/api/pandas.Series.argmin.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
