beliefer commented on PR #39091:
URL: https://github.com/apache/spark/pull/39091#issuecomment-1455360592
@hvanhovell @grundprinzip @HyukjinKwon @zhengruifeng @amaliujia Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
beliefer commented on PR #39091:
URL: https://github.com/apache/spark/pull/39091#issuecomment-1455279364
> @beliefer can you please remove the is_observation code path? And take
another look at the protocol. Otherwise I think it looks good.
is_observation code path has been removed.
beliefer commented on PR #39091:
URL: https://github.com/apache/spark/pull/39091#issuecomment-1428966021
> @beliefer will take a look today. Thanks for your hard work and patience!
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message,
beliefer commented on PR #39091:
URL: https://github.com/apache/spark/pull/39091#issuecomment-1427479417
ping @hvanhovell Could you review again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
beliefer commented on PR #39091:
URL: https://github.com/apache/spark/pull/39091#issuecomment-1383316479
ping @hvanhovell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
beliefer commented on PR #39091:
URL: https://github.com/apache/spark/pull/39091#issuecomment-1376762870
It seems the failure is unrelated with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
beliefer commented on PR #39091:
URL: https://github.com/apache/spark/pull/39091#issuecomment-1375067246
> In particular, the discussion on the `isObservation` flag in the proto
message needs to be addressed to simplify.
Hi, @grundprinzip . In fact, I removed the `Observation` that
beliefer commented on PR #39091:
URL: https://github.com/apache/spark/pull/39091#issuecomment-1371935451
ping @hvanhovell @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
beliefer commented on PR #39091:
URL: https://github.com/apache/spark/pull/39091#issuecomment-1368190192
ping @hvanhovell @grundprinzip @zhengruifeng @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
beliefer commented on PR #39091:
URL: https://github.com/apache/spark/pull/39091#issuecomment-1365847958
ping @grundprinzip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
beliefer commented on PR #39091:
URL: https://github.com/apache/spark/pull/39091#issuecomment-1360966070
ping @hvanhovell @grundprinzip @zhengruifeng @amaliujia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
beliefer commented on PR #39091:
URL: https://github.com/apache/spark/pull/39091#issuecomment-1359204590
> I don't have enough experience if it's worth it to do another full round
trip to the server for that. Can we experiment for now in just immediately
returning them? The observed
beliefer commented on PR #39091:
URL: https://github.com/apache/spark/pull/39091#issuecomment-1359204069
> @beliefer can we just send them as part of the `ExecutePlanResponse` at
the end of the query? Doing another RPC seems a bit wasteful, and it means we
have to track query state in the
beliefer commented on PR #39091:
URL: https://github.com/apache/spark/pull/39091#issuecomment-1357520476
> I think it would be possible to add another result batch type for observed
metrics and simply pass them at the end.
I have an idea:
1. cache the `Observation` at server.
beliefer commented on PR #39091:
URL: https://github.com/apache/spark/pull/39091#issuecomment-1356003824
> @beliefer thanks for working on this. I have one question how are we going
to get the observed metrics to the client? This seems to be missing from the
implementation. One of the
15 matches
Mail list logo
