[GitHub] [spark] beliefer commented on pull request #40396: [SPARK-42772][SQL] Change the default value of JDBC options about push down to true

2023-03-15 Thread via GitHub
beliefer commented on PR #40396: URL: https://github.com/apache/spark/pull/40396#issuecomment-1471226525 @dongjoon-hyun @cloud-fan @huaxingao @sadikovi Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [spark] beliefer commented on pull request #40396: [SPARK-42772][SQL] Change the default value of JDBC options about push down to true

2023-03-15 Thread via GitHub
beliefer commented on PR #40396: URL: https://github.com/apache/spark/pull/40396#issuecomment-1469534683 > Thank you for update. BTW, `JDBCDialect` is a documented developer API. We should not change the default value. We should keep the original default value to avoid a breaking change to

[GitHub] [spark] beliefer commented on pull request #40396: [SPARK-42772][SQL] Change the default value of JDBC options about push down to true

2023-03-13 Thread via GitHub
beliefer commented on PR #40396: URL: https://github.com/apache/spark/pull/40396#issuecomment-1465922700 ping @huaxingao cc @cloud-fan @sadikovi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to