[GitHub] [spark] beliefer edited a comment on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function
beliefer edited a comment on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-651601992 @hvanhovell Thanks. 1.Yes, this PR follows up the implement of `LEAD/LEG`, so `NTH_VALUE` is the same as `LEAD/LEG`, only works for an unbounded frame (`UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING`). If we surely need to support bounded frame, I think we should consider `LEAD/LEG/NTH_VALUE` together. I will open another PR for this work. 2.I have checked PostgreSQL, Vertica, Oracle, Redshift, Presto, Teradata, `NTH_VALUE` is always used as a window function, not as an aggregate function. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer edited a comment on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function
beliefer edited a comment on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-651601992 @hvanhovell Thanks. 1.Yes, this PR follows up the implement of `LEAD/LEG`, so `NTH_VALUE` is the same as `LEAD/LEG`, only works for an unbounded frame (`UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING`). If we surely need to support bounded frame, I will open another PR for this work. 2.I have checked PostgreSQL, Vertica, Oracle, Redshift, Presto, Teradata, `NTH_VALUE` is always used as a window function, not as an aggregate function. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer edited a comment on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function
beliefer edited a comment on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-651601992 @hvanhovell Thanks. 1.Yes, this PR follows up the implement of `LEAD/LEG`, so `NTH_VALUE` is the same as `LEAD/LEG`, only works for an unbounded frame (`UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING`). 2.I have checked PostgreSQL, Vertica, Oracle, Redshift, Presto, Teradata, `NTH_VALUE` is always used as a window function, not as an aggregate function. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer edited a comment on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function
beliefer edited a comment on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-651601992 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
