[GitHub] [spark] bersprockets commented on a diff in pull request #37825: [SPARK-40382][SQL] Group distinct aggregate expressions by semantically equivalent children in `RewriteDistinctAggregates`

2022-10-11 Thread GitBox
bersprockets commented on code in PR #37825: URL: https://github.com/apache/spark/pull/37825#discussion_r992871693 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala: ## @@ -254,7 +254,9 @@ object RewriteDistinctAggregates

[GitHub] [spark] bersprockets commented on a diff in pull request #37825: [SPARK-40382][SQL] Group distinct aggregate expressions by semantically equivalent children in `RewriteDistinctAggregates`

2022-10-01 Thread GitBox
bersprockets commented on code in PR #37825: URL: https://github.com/apache/spark/pull/37825#discussion_r985123478 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala: ## @@ -402,7 +405,28 @@ object RewriteDistinctAggregates

[GitHub] [spark] bersprockets commented on a diff in pull request #37825: [SPARK-40382][SQL] Group distinct aggregate expressions by semantically equivalent children in `RewriteDistinctAggregates`

2022-09-26 Thread GitBox
bersprockets commented on code in PR #37825: URL: https://github.com/apache/spark/pull/37825#discussion_r980641159 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala: ## @@ -218,9 +218,16 @@ object RewriteDistinctAggregates

[GitHub] [spark] bersprockets commented on a diff in pull request #37825: [SPARK-40382][SQL] Group distinct aggregate expressions by semantically equivalent children in `RewriteDistinctAggregates`

2022-09-25 Thread GitBox
bersprockets commented on code in PR #37825: URL: https://github.com/apache/spark/pull/37825#discussion_r979489753 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala: ## @@ -213,7 +213,16 @@ object RewriteDistinctAggregates

[GitHub] [spark] bersprockets commented on a diff in pull request #37825: [SPARK-40382][SQL] Group distinct aggregate expressions by semantically equivalent children in `RewriteDistinctAggregates`

2022-09-25 Thread GitBox
bersprockets commented on code in PR #37825: URL: https://github.com/apache/spark/pull/37825#discussion_r979487585 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala: ## @@ -291,7 +298,8 @@ object RewriteDistinctAggregates

[GitHub] [spark] bersprockets commented on a diff in pull request #37825: [SPARK-40382][SQL] Group distinct aggregate expressions by semantically equivalent children in `RewriteDistinctAggregates`

2022-09-24 Thread GitBox
bersprockets commented on code in PR #37825: URL: https://github.com/apache/spark/pull/37825#discussion_r979267219 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala: ## @@ -213,7 +213,16 @@ object RewriteDistinctAggregates

[GitHub] [spark] bersprockets commented on a diff in pull request #37825: [SPARK-40382][SQL] Group distinct aggregate expressions by semantically equivalent children in `RewriteDistinctAggregates`

2022-09-11 Thread GitBox
bersprockets commented on code in PR #37825: URL: https://github.com/apache/spark/pull/37825#discussion_r967860756 ## sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala: ## @@ -1451,6 +1451,22 @@ class DataFrameAggregateSuite extends QueryTest val