[GitHub] [spark] c21 commented on a diff in pull request #37264: [SPARK-39849][SQL] Dataset.as(StructType) fills missing new columns with null value

2022-07-28 Thread GitBox
c21 commented on code in PR #37264: URL: https://github.com/apache/spark/pull/37264#discussion_r932857471 ## sql/core/src/test/scala/org/apache/spark/sql/DataFrameAsSchemaSuite.scala: ## @@ -46,15 +46,11 @@ class DataFrameAsSchemaSuite extends QueryTest with SharedSparkSession

[GitHub] [spark] c21 commented on a diff in pull request #37264: [SPARK-39849][SQL] Dataset.as(StructType) fills missing new columns with null value

2022-07-24 Thread GitBox
c21 commented on code in PR #37264: URL: https://github.com/apache/spark/pull/37264#discussion_r928226213 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala: ## @@ -172,39 +172,55 @@ object Project { expected.map { f =>