[GitHub] [spark] cloud-fan commented on a change in pull request #28016: [SPARK-31238][SQL][test-hive1.2] Rebase dates to/from Julian calendar in write/read for ORC datasource

2020-03-25 Thread GitBox 
cloud-fan commented on a change in pull request #28016: 
[SPARK-31238][SQL][test-hive1.2] Rebase dates to/from Julian calendar in 
write/read for ORC datasource
URL: https://github.com/apache/spark/pull/28016#discussion_r398329582
 
 

 ##
 File path: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala
 ##
 @@ -32,6 +32,7 @@ import org.apache.spark.sql.AnalysisException
 import org.apache.spark.sql.catalyst.InternalRow
 import org.apache.spark.sql.catalyst.expressions._
 import org.apache.spark.sql.catalyst.util._
+import org.apache.spark.sql.execution.datasources.DaysWritable
 
 Review comment:
   unnecessary change


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #28016: [SPARK-31238][SQL][test-hive1.2] Rebase dates to/from Julian calendar in write/read for ORC datasource

2020-03-25 Thread GitBox 
cloud-fan commented on a change in pull request #28016: 
[SPARK-31238][SQL][test-hive1.2] Rebase dates to/from Julian calendar in 
write/read for ORC datasource
URL: https://github.com/apache/spark/pull/28016#discussion_r398329428
 
 

 ##
 File path: 
sql/core/v1.2/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnVector.java
 ##
 @@ -42,6 +43,7 @@
   private DecimalColumnVector decimalData;
   private TimestampColumnVector timestampData;
 
 Review comment:
   does ORC have `DateColumnVector`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #28016: [SPARK-31238][SQL][test-hive1.2] Rebase dates to/from Julian calendar in write/read for ORC datasource

2020-03-25 Thread GitBox 
cloud-fan commented on a change in pull request #28016: 
[SPARK-31238][SQL][test-hive1.2] Rebase dates to/from Julian calendar in 
write/read for ORC datasource
URL: https://github.com/apache/spark/pull/28016#discussion_r398329137
 
 

 ##
 File path: 
sql/core/v1.2/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnVector.java
 ##
 @@ -130,7 +138,13 @@ public short getShort(int rowId) {
 
   @Override
   public int getInt(int rowId) {
-return (int) longData.vector[getRowIndex(rowId)];
+int index = getRowIndex(rowId);
+int value = (int) longData.vector[index];
 
 Review comment:
   nit: `int value = (int) longData.vector[getRowIndex(rowId)];`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #28016: [SPARK-31238][SQL][test-hive1.2] Rebase dates to/from Julian calendar in write/read for ORC datasource

2020-03-25 Thread GitBox 
cloud-fan commented on a change in pull request #28016: 
[SPARK-31238][SQL][test-hive1.2] Rebase dates to/from Julian calendar in 
write/read for ORC datasource
URL: https://github.com/apache/spark/pull/28016#discussion_r398327978
 
 

 ##
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DaysWritable.scala
 ##
 @@ -35,11 +35,12 @@ import 
org.apache.spark.sql.catalyst.util.DateTimeUtils.{rebaseGregorianToJulian
  * @param julianDays The number of days since the epoch 1970-01-01 in
  *   Julian calendar.
  */
-private[hive] class DaysWritable(
+class DaysWritable(
 var gregorianDays: Int,
 var julianDays: Int)
   extends DateWritable {
 
 Review comment:
   We probably need to duplicate this class in v1.2 and v2.3 source code.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org