[GitHub] [spark] cloud-fan commented on a change in pull request #29277: [SPARK-32421][SQL] Add code-gen for shuffled hash join

2020-07-30 Thread GitBox
cloud-fan commented on a change in pull request #29277: URL: https://github.com/apache/spark/pull/29277#discussion_r463417316 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala ## @@ -903,6 +904,10 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #29277: [SPARK-32421][SQL] Add code-gen for shuffled hash join

2020-07-30 Thread GitBox
cloud-fan commented on a change in pull request #29277: URL: https://github.com/apache/spark/pull/29277#discussion_r463415144 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala ## @@ -903,6 +904,10 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #29277: [SPARK-32421][SQL] Add code-gen for shuffled hash join

2020-07-30 Thread GitBox
cloud-fan commented on a change in pull request #29277: URL: https://github.com/apache/spark/pull/29277#discussion_r463382990 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala ## @@ -903,6 +904,10 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #29277: [SPARK-32421][SQL] Add code-gen for shuffled hash join

2020-07-30 Thread GitBox
cloud-fan commented on a change in pull request #29277: URL: https://github.com/apache/spark/pull/29277#discussion_r462759609 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -70,4 +74,54 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #29277: [SPARK-32421][SQL] Add code-gen for shuffled hash join

2020-07-29 Thread GitBox
cloud-fan commented on a change in pull request #29277: URL: https://github.com/apache/spark/pull/29277#discussion_r462369012 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala ## @@ -316,6 +318,387 @@ trait HashJoin extends BaseJoinExec

[GitHub] [spark] cloud-fan commented on a change in pull request #29277: [SPARK-32421][SQL] Add code-gen for shuffled hash join

2020-07-29 Thread GitBox
cloud-fan commented on a change in pull request #29277: URL: https://github.com/apache/spark/pull/29277#discussion_r462035327 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala ## @@ -316,6 +318,387 @@ trait HashJoin extends BaseJoinExec