cloud-fan commented on code in PR #36519:
URL: https://github.com/apache/spark/pull/36519#discussion_r871440865
##########
sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala:
##########
@@ -605,6 +605,20 @@ class DataFrameSuite extends QueryTest
)
}
+ test("offset") {
+ checkAnswer(
+ testData.offset(90),
+ testData.collect().drop(90).toSeq)
+
+ checkAnswer(
+ arrayData.toDF().offset(99),
+ arrayData.collect().drop(99).map(r =>
Row.fromSeq(r.productIterator.toSeq)))
+
+ checkAnswer(
+ mapData.toDF().offset(99),
+ mapData.collect().drop(99).map(r =>
Row.fromSeq(r.productIterator.toSeq)))
Review Comment:
can we test a few combinations? like limit followed by offset, and offset
followed by limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
