[GitHub] [spark] cloud-fan commented on a diff in pull request #40300: [SPARK-42683] Automatically rename conflicting metadata columns

cloud-fan commented on code in PR #40300: URL: https://github.com/apache/spark/pull/40300#discussion_r1151495057 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala: ## @@ -295,8 +297,9 @@ object FileSourceStrategy extends Strategy

[GitHub] [spark] cloud-fan commented on a diff in pull request #40300: [SPARK-42683] Automatically rename conflicting metadata columns

cloud-fan commented on code in PR #40300: URL: https://github.com/apache/spark/pull/40300#discussion_r1151490309 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsMetadataColumns.java: ## @@ -48,11 +47,22 @@ public interface SupportsMetadataColumns

[GitHub] [spark] cloud-fan commented on a diff in pull request #40300: [SPARK-42683] Automatically rename conflicting metadata columns

cloud-fan commented on code in PR #40300: URL: https://github.com/apache/spark/pull/40300#discussion_r1149997056 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryBaseTable.scala: ## @@ -297,8 +297,14 @@ abstract class InMemoryBaseTable(

[GitHub] [spark] cloud-fan commented on a diff in pull request #40300: [SPARK-42683] Automatically rename conflicting metadata columns

cloud-fan commented on code in PR #40300: URL: https://github.com/apache/spark/pull/40300#discussion_r1149347950 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryBaseTable.scala: ## @@ -297,8 +297,14 @@ abstract class InMemoryBaseTable(

[GitHub] [spark] cloud-fan commented on a diff in pull request #40300: [SPARK-42683] Automatically rename conflicting metadata columns

cloud-fan commented on code in PR #40300: URL: https://github.com/apache/spark/pull/40300#discussion_r1149329725 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryBaseTable.scala: ## @@ -297,8 +297,14 @@ abstract class InMemoryBaseTable(

[GitHub] [spark] cloud-fan commented on a diff in pull request #40300: [SPARK-42683] Automatically rename conflicting metadata columns

cloud-fan commented on code in PR #40300: URL: https://github.com/apache/spark/pull/40300#discussion_r1130583100 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala: ## @@ -340,13 +358,26 @@ trait ExposesMetadataColumns extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #40300: [SPARK-42683] Automatically rename conflicting metadata columns

cloud-fan commented on code in PR #40300: URL: https://github.com/apache/spark/pull/40300#discussion_r1130417773 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala: ## @@ -340,13 +358,26 @@ trait ExposesMetadataColumns extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #40300: [SPARK-42683] Automatically rename conflicting metadata columns

cloud-fan commented on code in PR #40300: URL: https://github.com/apache/spark/pull/40300#discussion_r1129169029 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala: ## @@ -42,6 +42,24 @@ abstract class LogicalPlan */ def

[GitHub] [spark] cloud-fan commented on a diff in pull request #40300: [SPARK-42683] Automatically rename conflicting metadata columns

cloud-fan commented on code in PR #40300: URL: https://github.com/apache/spark/pull/40300#discussion_r1129167837 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala: ## @@ -340,13 +358,26 @@ trait ExposesMetadataColumns extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #40300: [SPARK-42683] Automatically rename conflicting metadata columns

cloud-fan commented on code in PR #40300: URL: https://github.com/apache/spark/pull/40300#discussion_r1127321842 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala: ## @@ -42,6 +42,24 @@ abstract class LogicalPlan */ def

[GitHub] [spark] cloud-fan commented on a diff in pull request #40300: [SPARK-42683] Automatically rename conflicting metadata columns

cloud-fan commented on code in PR #40300: URL: https://github.com/apache/spark/pull/40300#discussion_r1127307622 ## sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala: ## @@ -2714,6 +2726,17 @@ class Dataset[T] private[sql]( */ def withColumn(colName: String,

[GitHub] [spark] cloud-fan commented on a diff in pull request #40300: [SPARK-42683] Automatically rename conflicting metadata columns

cloud-fan commented on code in PR #40300: URL: https://github.com/apache/spark/pull/40300#discussion_r1127307264 ## sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala: ## @@ -2714,6 +2726,17 @@ class Dataset[T] private[sql]( */ def withColumn(colName: String,