cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in
DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-521299935
LGTM, merging to master!
This is an automated message from the Apa
cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in
DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-521200205
retest this please
This is an automated message from the Apache Gi
cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in
DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-521119576
retest this please
This is an automated message from the Apache Gi
cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in
DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-520816943
LGTM except https://github.com/apache/spark/pull/25115#discussion_r313371566
--
cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in
DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-520814794
retest this please
This is an automated message from the Apache Gi
cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in
DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-518698777
LGTM except two comments
This is an automated message from the Apa
cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in
DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-518695136
retest this please
This is an automated message from the Apache Gi
cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in
DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-514939370
I vote for `SupportsDelete` with a simple method `deleteWhere`. We can have
the builder API later when we support the row-level del
cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in
DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-510488904
@xianyinxin thanks for working on it.
A few general questions:
1. do we need individual interfaces for UPDATE/DELETE/... o
cloud-fan commented on issue #25115: [SPARK-28351][SQL] Support DELETE in
DataSource V2
URL: https://github.com/apache/spark/pull/25115#issuecomment-510476616
ok to test
This is an automated message from the Apache Git Servic
10 matches
Mail list logo