[GitHub] [spark] cloud-fan commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP)

2020-04-03 Thread GitBox
cloud-fan commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP) URL: https://github.com/apache/spark/pull/28026#issuecomment-608510899 I just recalled that we tried to unify Hive table before, to support `CREATE TABLE ... USING hive`. And we already defined option

[GitHub] [spark] cloud-fan commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP)

2020-03-31 Thread GitBox
cloud-fan commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP) URL: https://github.com/apache/spark/pull/28026#issuecomment-607004494 OK let's flip the value of `spark.sql.legacy.createHiveTableByDefault.enabled` for 3.0, so we have more time to discuss this PR.

[GitHub] [spark] cloud-fan commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP)

2020-03-31 Thread GitBox
cloud-fan commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP) URL: https://github.com/apache/spark/pull/28026#issuecomment-606769368 You made a point that the same problem occurs for `STORED AS`/`ROW FORMAT DELIMITED`. How are we going to support them in the v2

[GitHub] [spark] cloud-fan commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP)

2020-03-31 Thread GitBox
cloud-fan commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP) URL: https://github.com/apache/spark/pull/28026#issuecomment-606746750 `EXTERNAL` is never supported in Spark native tables, and it's intentional. At least at that time, we thought `EXTERNAL` is a bad

[GitHub] [spark] cloud-fan commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP)

2020-03-31 Thread GitBox
cloud-fan commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP) URL: https://github.com/apache/spark/pull/28026#issuecomment-606619877 > Hive allows EXTERNAL with a custom LOCATION, so I don't think that Spark should prevent this from being passed to catalogs.

[GitHub] [spark] cloud-fan commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP)

2020-03-26 Thread GitBox
cloud-fan commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP) URL: https://github.com/apache/spark/pull/28026#issuecomment-604805210 I understand that we want to make Hive implements the v2 API eventually, but can we focus on syntax unification right now? Let's