[GitHub] [spark] cloud-fan commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype
cloud-fan commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-659183541 I don't think it's a good idea to diverge the behavior between in-memory and hive catalogs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype
cloud-fan commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-657368732 @ulysses-you does it work before this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype
cloud-fan commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-655292960 `NullType` is a stable public class, I don't think we can drop it. The intention is to only allow parsing `NullType` for the type string of legacy hive tables. But @HyukjinKwon is right that it also affects places like `from_csv`. Let's revert this part and think of a better solution. We don't document NullType in SQL reference. I think it's better to hide NullType from end-users. It's usually type-coercioned to other official types, and this PR forbids `NullType` if it leaks to the end (top columns). `df.show` is still OK to have `NullType` though. I agree that `NullType.simpleString` update can be put in a separate PR and discussed separately. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
