[GitHub] [spark] dilipbiswal commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-06-30 Thread GitBox
dilipbiswal commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-651976770 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [spark] dilipbiswal commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-06-29 Thread GitBox
dilipbiswal commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-651566036 Changes look good to me. This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [spark] dilipbiswal commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-06-25 Thread GitBox
dilipbiswal commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-649476962 Thanks @ulysses-you . cc @cloud-fan @viirya @maropu - Should we be more restrictive here and only copy properties if target and source format and serde match up ? or its

[GitHub] [spark] dilipbiswal commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-06-24 Thread GitBox
dilipbiswal commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-649105089 @ulysses-you Thanks. Do we know the behavior of hive for this case i.e parquet to orc or vice versa ? This

[GitHub] [spark] dilipbiswal commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-06-24 Thread GitBox
dilipbiswal commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-648661039 @ulysses-you I have a question. Per the syntax the source file format, row format can be different than the target. Say source format was parquet and target is orc, can we c