dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-531055915
@srowen Here is the rebase. Thanks for reviewing! :smile:
-
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-530203918
@srowen Fixed, with removing redundant `new` in `KafkaDataConsumerSuite`.
-
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-529835131
Here is the update, merging @HeartSaVioR's PR and rebased onto the latest
master.
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-523864982
@HeartSaVioR You are right. Thanks for the reasoning. @zsxwing Reverted.
--
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-523463288
@zsxwing Here it is. Fixed.
This is an aut
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-522823382
@HeartSaVioR You are right. Rebased onto the latest master, resolve
parameter inconsistencies, and remove t
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-522654493
@srowen Thanks for your kind review. It now rebased onto the latest master!
:smile: cc/ @HeartSaVioR
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-522202301
@zsxwing @srowen Here is the fix.
This is
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-522042226
@zsxwing @srowen Rebased onto the latest master. Could you have a look? It
seems like almost done.
--
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-518717011
@zsxwing @srowen Here is the fix. Add to that, have you ever thought about a
new name for `KafkaOffsetReade
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-517891763
Ping @zsxwing @srowen
This is an automated
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-514697187
Here is the fix. Yes, you are right - [The official documentation states
that 'Note that multiple headers m
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-513525651
Here is the commit for the documentation. cc/ @srowen @HeartSaVioR
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-513204523
Here is the update, rebased against the latest master.
@zsxwing About the Kafka client version, [the
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-513122669
Retest this please
This is an automated me
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-506557922
@HeartSaVioR Thanks for notifying me. Here it is!
-
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-505034592
Here is the update, rebased against latest master which includes #24942.
@HeartSaVioR Thanks for the
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-503357563
@srowen Thanks for the immediate feedback. Here is the fix! :)
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-503220122
@srowen @zsxwing Rebased onto the latest master, with applying the comments.
Could you have a look when you
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-475280370
@srowen @dongjoon-hyun @zsxwing @tdas @dbtsai
Dear committers,
Sorry to bother you, but there'
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka
headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#issuecomment-474430215
@HeartSaVioR @zsxwing Sorry for the late reply. I have been working on
adding `includeHeader` option with t
21 matches
Mail list logo
