[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-07 Thread GitBox
dongjoon-hyun commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466838962 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFiltersBase.scala ## @@ -37,12 +40,45 @@ trait

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466831167 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFiltersBase.scala ## @@ -37,12 +40,44 @@ trait

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466828786 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFiltersBase.scala ## @@ -37,12 +40,44 @@ trait

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466828593 ## File path: sql/core/v2.3/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala ## @@ -93,155 +92,200 @@ class

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466710704 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFiltersBase.scala ## @@ -37,12 +40,44 @@ trait

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466708125 ## File path: sql/core/v2.3/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala ## @@ -93,155 +92,200 @@ class

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466707364 ## File path: sql/core/v2.3/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala ## @@ -93,155 +92,200 @@ class

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466706196 ## File path: sql/core/v1.2/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala ## @@ -231,37 +229,37 @@ private[sql]

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466695536 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFiltersBase.scala ## @@ -37,12 +40,44 @@ trait

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466695536 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFiltersBase.scala ## @@ -37,12 +40,44 @@ trait

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466632459 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFiltersBase.scala ## @@ -37,12 +40,44 @@ trait