[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29111: [SPARK-29292][SQL][ML] Update rest of default modules (Hive, ML, etc) for Scala 2.13 compilation
dongjoon-hyun commented on a change in pull request #29111:
URL: https://github.com/apache/spark/pull/29111#discussion_r454784921
##
File path: mllib/src/main/scala/org/apache/spark/ml/Estimator.scala
##
@@ -76,7 +76,7 @@ abstract class Estimator[M <: Model[M]] extends PipelineStage
{
* @return fitted models, matching the input parameter maps
*/
@Since("2.0.0")
- def fit(dataset: Dataset[_], paramMaps: Array[ParamMap]): Seq[M] = {
+ def fit(dataset: Dataset[_], paramMaps: Seq[ParamMap]): Seq[M] = {
Review comment:
cc @mengxr and @gatorsmile
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29111: [SPARK-29292][SQL][ML] Update rest of default modules (Hive, ML, etc) for Scala 2.13 compilation
dongjoon-hyun commented on a change in pull request #29111:
URL: https://github.com/apache/spark/pull/29111#discussion_r454784282
##
File path: examples/src/main/scala/org/apache/spark/examples/SparkKMeans.scala
##
@@ -102,5 +102,10 @@ object SparkKMeans {
kPoints.foreach(println)
spark.stop()
}
+
+ private def mergeResults(a: (Vector[Double], Int),
+ b: (Vector[Double], Int)): (Vector[Double], Int) = {
Review comment:
nit. Indentation?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29111: [SPARK-29292][SQL][ML] Update rest of default modules (Hive, ML, etc) for Scala 2.13 compilation
dongjoon-hyun commented on a change in pull request #29111:
URL: https://github.com/apache/spark/pull/29111#discussion_r454639188
##
File path: mllib/src/main/scala/org/apache/spark/ml/Estimator.scala
##
@@ -26,7 +27,7 @@ import org.apache.spark.sql.Dataset
/**
* Abstract class for estimators that fit models to data.
*/
-abstract class Estimator[M <: Model[M]] extends PipelineStage {
+abstract class Estimator[M <: Model[M] : ClassTag] extends PipelineStage {
Review comment:
Unfortunately, MiMi seems to complain on this and a few others like this.
```
[error] * method this()Unit in class org.apache.spark.ml.Estimator does not
have a correspondent in current version
4232
[error]filter with:
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.Estimator.this")
4233
[error] * method this()Unit in class org.apache.spark.ml.Predictor does not
have a correspondent in current version
4234
[error]filter with:
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.Predictor.this")
4235
[error] * method this()Unit in class
org.apache.spark.ml.classification.ProbabilisticClassifier does not have a
correspondent in current version
4236
[error]filter with:
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.classification.ProbabilisticClassifier.this")
4237
[error] * method this()Unit in class
org.apache.spark.ml.classification.Classifier does not have a correspondent in
current version
4238
[error]filter with:
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.classification.Classifier.this")
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
