[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38003: [SPARK-40565][SQL] Don't push non-deterministic filters to V2 file sources

2022-10-06 Thread GitBox
dongjoon-hyun commented on code in PR #38003: URL: https://github.com/apache/spark/pull/38003#discussion_r989508900 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScanBuilder.scala: ## @@ -70,8 +70,9 @@ abstract class FileScanBuilder( }

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38003: [SPARK-40565][SQL] Don't push non-deterministic filters to V2 file sources

2022-10-06 Thread GitBox
dongjoon-hyun commented on code in PR #38003: URL: https://github.com/apache/spark/pull/38003#discussion_r989508498 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScanBuilder.scala: ## @@ -70,8 +70,9 @@ abstract class FileScanBuilder( }

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38003: [SPARK-40565][SQL] Don't push non-deterministic filters to V2 file sources

2022-10-06 Thread GitBox
dongjoon-hyun commented on code in PR #38003: URL: https://github.com/apache/spark/pull/38003#discussion_r989283160 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScanBuilder.scala: ## @@ -70,8 +70,9 @@ abstract class FileScanBuilder( }

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38003: [SPARK-40565][SQL] Don't push non-deterministic filters to V2 file sources

2022-10-06 Thread GitBox
dongjoon-hyun commented on code in PR #38003: URL: https://github.com/apache/spark/pull/38003#discussion_r989283160 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScanBuilder.scala: ## @@ -70,8 +70,9 @@ abstract class FileScanBuilder( }

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38003: [SPARK-40565][SQL] Don't push non-deterministic filters to V2 file sources

2022-10-06 Thread GitBox
dongjoon-hyun commented on code in PR #38003: URL: https://github.com/apache/spark/pull/38003#discussion_r988637745 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScanBuilder.scala: ## @@ -70,8 +70,9 @@ abstract class FileScanBuilder( }

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38003: [SPARK-40565][SQL] Don't push non-deterministic filters to V2 file sources

2022-09-26 Thread GitBox
dongjoon-hyun commented on code in PR #38003: URL: https://github.com/apache/spark/pull/38003#discussion_r980419475 ## sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/PruneFileSourcePartitionsSuite.scala: ## @@ -140,6 +140,24 @@ class

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38003: [SPARK-40565][SQL] Don't push non-deterministic filters to V2 file sources

2022-09-26 Thread GitBox
dongjoon-hyun commented on code in PR #38003: URL: https://github.com/apache/spark/pull/38003#discussion_r980419475 ## sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/PruneFileSourcePartitionsSuite.scala: ## @@ -140,6 +140,24 @@ class