dongjoon-hyun commented on issue #27330: [SPARK-30630][ML] Remove numTrees in
GBT in 3.0.0
URL: https://github.com/apache/spark/pull/27330#issuecomment-579615879
I gave +1 for the above one and this PR .
This is an automated
dongjoon-hyun commented on issue #27330: [SPARK-30630][ML] Remove numTrees in
GBT in 3.0.0
URL: https://github.com/apache/spark/pull/27330#issuecomment-579615574
I don't think it's an offend. (including your arguments). All comments are
valid opinions.
dongjoon-hyun commented on issue #27330: [SPARK-30630][ML] Remove numTrees in
GBT in 3.0.0
URL: https://github.com/apache/spark/pull/27330#issuecomment-579615121
Please add the above examples. Otherwise, people don't understand what we
did. Additionally, please add the following.
dongjoon-hyun commented on issue #27330: [SPARK-30630][ML] Remove numTrees in
GBT in 3.0.0
URL: https://github.com/apache/spark/pull/27330#issuecomment-579612360
I totally agree with you. Your guideline also sounds reasonable.
dongjoon-hyun commented on issue #27330: [SPARK-30630][ML] Remove numTrees in
GBT in 3.0.0
URL: https://github.com/apache/spark/pull/27330#issuecomment-579611370
We deleted public API even in minor versions like SPARK-28780.
dongjoon-hyun commented on issue #27330: [SPARK-30630][ML] Remove numTrees in
GBT in 3.0.0
URL: https://github.com/apache/spark/pull/27330#issuecomment-579610979
`Delete the incorrect setWeightCol method in LinearSVCModel` at 2.3.4,
2.4.4, 3.0.0?
dongjoon-hyun commented on issue #27330: [SPARK-30630][ML] Remove numTrees in
GBT in 3.0.0
URL: https://github.com/apache/spark/pull/27330#issuecomment-579610371
SPARK-24918 adds `Executor Plugin` at 2.4.0.
SPARK-29399 removed it at 3.0.0.
dongjoon-hyun commented on issue #27330: [SPARK-30630][ML] Remove numTrees in
GBT in 3.0.0
URL: https://github.com/apache/spark/pull/27330#issuecomment-579608768
Let me rephrase your words~ So, only 2.0.0 or 3.0.0 can do deprecation .
Then, 3.0.0 or 4.0.0 can do the removal?
dongjoon-hyun commented on issue #27330: [SPARK-30630][ML] Remove numTrees in
GBT in 3.0.0
URL: https://github.com/apache/spark/pull/27330#issuecomment-579608393
This is removed at 3.0.0 at the major version, isn't it?
This
dongjoon-hyun commented on issue #27330: [SPARK-30630][ML] Remove numTrees in
GBT in 3.0.0
URL: https://github.com/apache/spark/pull/27330#issuecomment-579608300
We didn't remove any API in the maintenance release.
This is
dongjoon-hyun commented on issue #27330: [SPARK-30630][ML] Remove numTrees in
GBT in 3.0.0
URL: https://github.com/apache/spark/pull/27330#issuecomment-579607779
We don't remove the API at 2.4.6, @gatorsmile . The next of 2.4.5 is 2.4.6.
> Did we deprecate any API in the maintenance
dongjoon-hyun commented on issue #27330: [SPARK-30630][ML] Remove numTrees in
GBT in 3.0.0
URL: https://github.com/apache/spark/pull/27330#issuecomment-579587556
@gatorsmile . As mentioned in the PR description, we deprecated this at
2.4.5 which will be released before 3.0.0. Do you mean
dongjoon-hyun commented on issue #27330: [SPARK-30630][ML] Remove numTrees in
GBT in 3.0.0
URL: https://github.com/apache/spark/pull/27330#issuecomment-578374658
Never late~ Thank you, @zhengruifeng . :)
This is an automated
dongjoon-hyun commented on issue #27330: [SPARK-30630][ML] Remove numTrees in
GBT in 3.0.0
URL: https://github.com/apache/spark/pull/27330#issuecomment-578283214
Merged to master. Thank you, @huaxingao and @srowen .
This is
dongjoon-hyun commented on issue #27330: [SPARK-30630][ML] Remove numTrees in
GBT in 3.0.0
URL: https://github.com/apache/spark/pull/27330#issuecomment-578230952
Thank you, @srowen .
This is an automated message from the
dongjoon-hyun commented on issue #27330: [SPARK-30630][ML] Remove numTrees in
GBT in 3.0.0
URL: https://github.com/apache/spark/pull/27330#issuecomment-578066905
cc @zhengruifeng
This is an automated message from the Apache
dongjoon-hyun commented on issue #27330: [SPARK-30630][ML] Remove numTrees in
GBT in 3.0.0
URL: https://github.com/apache/spark/pull/27330#issuecomment-578031486
Retest this please.
This is an automated message from the
dongjoon-hyun commented on issue #27330: [SPARK-30630][ML] Remove numTrees in
GBT in 3.0.0
URL: https://github.com/apache/spark/pull/27330#issuecomment-578005404
@huaxingao . We need to deprecate this in `branch-2.4` first. We can not
proceed in the reverse order. Could you make a PR for
18 matches
Mail list logo
