gengliangwang commented on a change in pull request #28803:
URL: https://github.com/apache/spark/pull/28803#discussion_r451280315
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##########
@@ -184,20 +188,52 @@ private[ui] class AllJobsPage(parent: JobsTab, store:
AppStatusStore) extends We
val eventArrayAsStr =
(jobEventJsonAsStrSeq ++ executorEventJsonAsStrSeq).mkString("[", ",",
"]")
- <span class="expand-application-timeline">
- <span class="expand-application-timeline-arrow arrow-closed"></span>
- <a data-toggle="tooltip" title={ToolTips.JOB_TIMELINE}
data-placement="top">
- Event Timeline
- </a>
- </span> ++
- <div id="application-timeline" class="collapsed">
- <div class="control-panel">
- <div id="application-timeline-zoom-lock">
- <input type="checkbox"></input>
- <span>Enable zooming</span>
+ if (totalPages > 0) {
+ <span class="expand-application-timeline">
+ <span class="expand-application-timeline-arrow arrow-closed"></span>
+ <a data-toggle="tooltip" title={ToolTips.JOB_TIMELINE}
data-placement="top">
+ Event Timeline
+ </a>
+ </span> ++
+ <div id="application-timeline" class="collapsed">
+ <div class="control-panel">
+ <div id="application-timeline-zoom-lock">
+ <input type="checkbox"></input>
+ <span>Enable zooming</span>
+ </div>
+ <div>
+ <form id={s"form-event-timeline-page"}
+ method="get"
+ action=""
+ class="form-inline justify-content-end"
+ style="width: 50%; margin-left: auto; margin-bottom: 0px;">
Review comment:
nit: shall we move the style to webui.css?
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##########
@@ -184,20 +188,52 @@ private[ui] class AllJobsPage(parent: JobsTab, store:
AppStatusStore) extends We
val eventArrayAsStr =
(jobEventJsonAsStrSeq ++ executorEventJsonAsStrSeq).mkString("[", ",",
"]")
- <span class="expand-application-timeline">
- <span class="expand-application-timeline-arrow arrow-closed"></span>
- <a data-toggle="tooltip" title={ToolTips.JOB_TIMELINE}
data-placement="top">
- Event Timeline
- </a>
- </span> ++
- <div id="application-timeline" class="collapsed">
- <div class="control-panel">
- <div id="application-timeline-zoom-lock">
- <input type="checkbox"></input>
- <span>Enable zooming</span>
+ if (totalPages > 0) {
+ <span class="expand-application-timeline">
+ <span class="expand-application-timeline-arrow arrow-closed"></span>
+ <a data-toggle="tooltip" title={ToolTips.JOB_TIMELINE}
data-placement="top">
+ Event Timeline
+ </a>
+ </span> ++
+ <div id="application-timeline" class="collapsed">
+ <div class="control-panel">
+ <div id="application-timeline-zoom-lock">
+ <input type="checkbox"></input>
+ <span>Enable zooming</span>
+ </div>
+ <div>
+ <form id={s"form-event-timeline-page"}
+ method="get"
+ action=""
+ class="form-inline justify-content-end"
+ style="width: 50%; margin-left: auto; margin-bottom: 0px;">
+ <label>Jobs:
+ {totalJobs}
+ .
+ {totalPages}
+ Pages. Jump to</label>
+ <input type="text"
+ name="jobs.eventTimelinePageNumber"
+ id={s"form-event-timeline-page-no"}
Review comment:
Nit: I find similar code in StagePage.scala. But why do we need
`{s".."}` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
