[GitHub] [spark] gengliangwang commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
gengliangwang commented on pull request #28803: URL: https://github.com/apache/spark/pull/28803#issuecomment-655283658 @sarutak I am really sorry I missed your ping last week. The perf problem is resolved in https://github.com/apache/spark/pull/28806. If we want to avoid perf issue in the long term, I think we can avoid rendering the timeline by default. I am +0 with the proposal. The pagination makes the visualization simpler, but also makes the UI usage more complex. If you insist, let's merge this one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
gengliangwang commented on pull request #28803: URL: https://github.com/apache/spark/pull/28803#issuecomment-655278687 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
gengliangwang commented on pull request #28803: URL: https://github.com/apache/spark/pull/28803#issuecomment-643070561 > Even if no performance issue exists, lots of items rendered in one page can be too noisy. OK, how about we merge #28806 to 3.0/2.4 first. And start the pagination from 3.1 if you insist? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
gengliangwang commented on pull request #28803: URL: https://github.com/apache/spark/pull/28803#issuecomment-643067149 @sarutak I just created https://github.com/apache/spark/pull/28806. I believe downgrading the vis version is a safer solution. We need to hotfix this to Spark 3.0 ASAP This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
gengliangwang commented on pull request #28803: URL: https://github.com/apache/spark/pull/28803#issuecomment-643059905 Let me create a PR for downgrading to 4.21.0 now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
gengliangwang commented on pull request #28803: URL: https://github.com/apache/spark/pull/28803#issuecomment-643059040 So, I am actually -1 in this solution, for two reasons: 1. if there are many stages in one job, the perf issue still exists 2. the two paginations in one page seem weird. I tried a different version 4.21.0 from https://cdnjs.com/libraries/vis The infinite drawing issue seems better if the zoom is not enabled. How about we changing to that version? or, just reverting https://github.com/apache/spark/pull/28192? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
gengliangwang commented on pull request #28803: URL: https://github.com/apache/spark/pull/28803#issuecomment-643042963 @sarutak I just confirmed that the issue is caused by #28192 . The issus can't be reproduced before the change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
gengliangwang commented on pull request #28803: URL: https://github.com/apache/spark/pull/28803#issuecomment-642941333  I think we should make the two pagination sections consistent This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
gengliangwang commented on pull request #28803: URL: https://github.com/apache/spark/pull/28803#issuecomment-642941206 @sarutak Thanks for the quick fix. I try on my local setup and it works. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
