[GitHub] [spark] gengliangwang commented on pull request #37840: [SPARK-40416][SQL] Move subquery expression CheckAnalysis error messages to use the new error framework

2022-09-20 Thread GitBox
gengliangwang commented on PR #37840: URL: https://github.com/apache/spark/pull/37840#issuecomment-1252746471 Thanks, merging to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] gengliangwang commented on pull request #37840: [SPARK-40416][SQL] Move subquery expression CheckAnalysis error messages to use the new error framework

2022-09-16 Thread GitBox
gengliangwang commented on PR #37840: URL: https://github.com/apache/spark/pull/37840#issuecomment-1249703749 LGTM except one comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] gengliangwang commented on pull request #37840: [SPARK-40416][SQL] Move subquery expression CheckAnalysis error messages to use the new error framework

2022-09-13 Thread GitBox
gengliangwang commented on PR #37840: URL: https://github.com/apache/spark/pull/37840#issuecomment-1246243282 Hi @dtenedor, I have just merged the bug fix https://github.com/apache/spark/pull/37861. The query context should be set correctly in the AnlysisException. I believe the test