[GitHub] [spark] hvanhovell commented on a diff in pull request #39517: [SPARK-41993][SQL] Move RowEncoder to AgnosticEncoders

2023-01-13 Thread GitBox
hvanhovell commented on code in PR #39517: URL: https://github.com/apache/spark/pull/39517#discussion_r1069354107 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/AgnosticEncoder.scala: ## @@ -46,35 +46,42 @@ object AgnosticEncoders { override val

[GitHub] [spark] hvanhovell commented on a diff in pull request #39517: [SPARK-41993][SQL] Move RowEncoder to AgnosticEncoders

2023-01-12 Thread GitBox
hvanhovell commented on code in PR #39517: URL: https://github.com/apache/spark/pull/39517#discussion_r1068889994 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala: ## @@ -155,11 +169,19 @@ object ScalaReflection extends ScalaReflection {

[GitHub] [spark] hvanhovell commented on a diff in pull request #39517: [SPARK-41993][SQL] Move RowEncoder to AgnosticEncoders

2023-01-12 Thread GitBox
hvanhovell commented on code in PR #39517: URL: https://github.com/apache/spark/pull/39517#discussion_r1068889994 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala: ## @@ -155,11 +169,19 @@ object ScalaReflection extends ScalaReflection {

[GitHub] [spark] hvanhovell commented on a diff in pull request #39517: [SPARK-41993][SQL] Move RowEncoder to AgnosticEncoders

2023-01-12 Thread GitBox
hvanhovell commented on code in PR #39517: URL: https://github.com/apache/spark/pull/39517#discussion_r106785 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/AgnosticEncoder.scala: ## @@ -46,35 +46,42 @@ object AgnosticEncoders { override val

[GitHub] [spark] hvanhovell commented on a diff in pull request #39517: [SPARK-41993][SQL] Move RowEncoder to AgnosticEncoders

2023-01-12 Thread GitBox
hvanhovell commented on code in PR #39517: URL: https://github.com/apache/spark/pull/39517#discussion_r1068885292 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/RowEncoderSuite.scala: ## @@ -125,7 +125,7 @@ class RowEncoderSuite extends

[GitHub] [spark] hvanhovell commented on a diff in pull request #39517: [SPARK-41993][SQL] Move RowEncoder to AgnosticEncoders

2023-01-12 Thread GitBox
hvanhovell commented on code in PR #39517: URL: https://github.com/apache/spark/pull/39517#discussion_r1068884900 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala: ## @@ -377,27 +408,96 @@ object ScalaReflection extends ScalaReflection {

[GitHub] [spark] hvanhovell commented on a diff in pull request #39517: [SPARK-41993][SQL] Move RowEncoder to AgnosticEncoders

2023-01-11 Thread GitBox
hvanhovell commented on code in PR #39517: URL: https://github.com/apache/spark/pull/39517#discussion_r1067435036 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala: ## @@ -377,27 +408,96 @@ object ScalaReflection extends ScalaReflection {

[GitHub] [spark] hvanhovell commented on a diff in pull request #39517: [SPARK-41993][SQL] Move RowEncoder to AgnosticEncoders

2023-01-11 Thread GitBox
hvanhovell commented on code in PR #39517: URL: https://github.com/apache/spark/pull/39517#discussion_r1067433716 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala: ## @@ -306,7 +330,7 @@ object ScalaReflection extends ScalaReflection { *