[GitHub] [spark] hvanhovell commented on a diff in pull request #40217: [SPARK-42559][CONNECT] Implement DataFrameNaFunctions

2023-03-06 Thread via GitHub
hvanhovell commented on code in PR #40217: URL: https://github.com/apache/spark/pull/40217#discussion_r1126525999 ## connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/CheckConnectJvmClientCompatibility.scala: ## @@ -134,6 +135,9 @@ object

[GitHub] [spark] hvanhovell commented on a diff in pull request #40217: [SPARK-42559][CONNECT] Implement DataFrameNaFunctions

2023-03-05 Thread via GitHub
hvanhovell commented on code in PR #40217: URL: https://github.com/apache/spark/pull/40217#discussion_r1125825287 ## connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/DataFrameNaFunctionSuite.scala: ## @@ -0,0 +1,377 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] hvanhovell commented on a diff in pull request #40217: [SPARK-42559][CONNECT] Implement DataFrameNaFunctions

2023-03-03 Thread via GitHub
hvanhovell commented on code in PR #40217: URL: https://github.com/apache/spark/pull/40217#discussion_r1124643411 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala: ## @@ -0,0 +1,524 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] hvanhovell commented on a diff in pull request #40217: [SPARK-42559][CONNECT] Implement DataFrameNaFunctions

2023-03-03 Thread via GitHub
hvanhovell commented on code in PR #40217: URL: https://github.com/apache/spark/pull/40217#discussion_r1124642540 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala: ## @@ -0,0 +1,524 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] hvanhovell commented on a diff in pull request #40217: [SPARK-42559][CONNECT] Implement DataFrameNaFunctions

2023-03-03 Thread via GitHub
hvanhovell commented on code in PR #40217: URL: https://github.com/apache/spark/pull/40217#discussion_r1124627948 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala: ## @@ -0,0 +1,524 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] hvanhovell commented on a diff in pull request #40217: [SPARK-42559][CONNECT] Implement DataFrameNaFunctions

2023-03-03 Thread via GitHub
hvanhovell commented on code in PR #40217: URL: https://github.com/apache/spark/pull/40217#discussion_r1124600164 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala: ## @@ -0,0 +1,524 @@ +/* + * Licensed to the Apache Software