[GitHub] [spark] igreenfield commented on pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-29 Thread GitBox
igreenfield commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-621606974 @Ngone51 To clarify: We have one single long-running spark application to which we continuously submit jobs which are non-related to one another. These jobs may be

[GitHub] [spark] igreenfield commented on pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-29 Thread GitBox
igreenfield commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-621590368 we are running one-app but submit to it many tasks using spark-server so it has many tasks that belong to different requests. so in our case, we mostly use the `mdc.`

[GitHub] [spark] igreenfield commented on pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-29 Thread GitBox
igreenfield commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-621358014 Hi @cloud-fan, I think that if we will not merge all as part it will not have the benefit. as I answer in an earlier

[GitHub] [spark] igreenfield commented on pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-28 Thread GitBox
igreenfield commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-620989210 @ngone51 can you help understand what went wrong in the build? This is an automated message from the

[GitHub] [spark] igreenfield commented on pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-28 Thread GitBox
igreenfield commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-620460159 The failed test does not seems to be connected to the changes in the code This is an automated message

[GitHub] [spark] igreenfield commented on pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-27 Thread GitBox
igreenfield commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-619976944 log4j.appender.console.layout.ConversionPattern=%d{/MM/dd HH:mm:ss} %p [%X{appId}] [%X{appName}] %c{3} - %m%n ```

[GitHub] [spark] igreenfield commented on pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-27 Thread GitBox
igreenfield commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-619949637 Hi, @Ngone51 first thank for reviewing! about the pattern, it should be added but I think each will add what he needed and how he wanted it as it also supports adding

[GitHub] [spark] igreenfield commented on pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-26 Thread GitBox
igreenfield commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-619526963 @cloud-fan Could you please look at that? This is an automated message from the Apache Git Service. To