maropu commented on a change in pull request #27699: 
[SPARK-27924][SQL][FOLLOW-UP] Improve ANSI SQL Boolean-Predicate
URL: https://github.com/apache/spark/pull/27699#discussion_r384319947
 
 

 ##########
 File path: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/PredicateSuite.scala
 ##########
 @@ -523,34 +523,6 @@ class PredicateSuite extends SparkFunSuite with 
ExpressionEvalHelper {
   }
 
   val row0 = create_row(null)
 
 Review comment:
   Can you move this variable into the test `test("isunknown and 
isnotunknown")`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to